Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initializer modifier should be treated as constructor within ordering rule #404

Closed
shirotech opened this issue Feb 16, 2023 · 1 comment
Closed
Assignees

Comments

@shirotech
Copy link

shirotech commented Feb 16, 2023

In an upgradable proxy, there is no concept of "constructor", rather they have an initialize function with an initializer modifier. For example:

https://github.com/protofire/solhint/blob/master/lib/rules/order/ordering.js#L142

function initialize() public initializer {
  // initialize member properties here
}
@dbale-altoros
Copy link
Collaborator

This is fixed in this pr
#474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants