Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Blacklisting to Rulesets + Whitelisting #73

Closed
pablofullana opened this issue Oct 9, 2018 · 2 comments
Closed

Switch from Blacklisting to Rulesets + Whitelisting #73

pablofullana opened this issue Oct 9, 2018 · 2 comments
Assignees
@mariano-aguero

Comments

@pablofullana
Copy link
Contributor

Blacklisting is quite a tricky and tedious process. Requires many iterations and isn't straightforward at all.
Proposal is to evaluate switching this approach in favor of Rulesets + Whitelisting. Guess it that this will make Solhint setup simpler and more intuitive.
@pablofullana pablofullana added the evaluating Team will evaluate and decide if it's worth the effort label Oct 9, 2018
@pablofullana
Copy link
Contributor Author

@fvictorio we could discuss allowing something in the fashion of what is described in #27 as well

@pablofullana
Copy link
Contributor Author

Some code to start iterating over https://gist.github.com/pablofullana/5c1e062de0ef15e88996f3a0a17684fd

@mariano-aguero mariano-aguero mentioned this issue Nov 21, 2018
Merged
@mariano-aguero mariano-aguero mentioned this issue Dec 14, 2018
Merged
@pablofullana pablofullana removed the evaluating Team will evaluate and decide if it's worth the effort label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariano-aguero mariano-aguero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fvictorio @mariano-aguero @pablofullana