Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdk update modifies the metadata.json such that it is missing a newline on the final line #636

Closed
ghoneycutt opened this issue Mar 4, 2019 · 3 comments
Closed

pdk update modifies the metadata.json such that it is missing a newline on the final line #636

ghoneycutt opened this issue Mar 4, 2019 · 3 comments
Labels
JIRA JIRA Ticket Created

Comments

@ghoneycutt
Copy link

Describe the bug
When using pdk update the resulting metadata.json is missing a newline at the end of the file.

Here's an example.

https://github.com/ghoneycutt/puppet-module-rpcbind/pull/40/files#diff-490694a9db8f7a371538da1abe484314R77

To Reproduce
Run pdk update on a module.

Expected behavior
There is a new line character.

Additional context

  • Your PDK installation method: native packages
  • Your PDK version: 1.9.0
  • Your operating system / platform: macos mojave
@scotje scotje added feature JIRA JIRA Ticket Created labels Mar 19, 2019
@scotje
Copy link
Contributor

scotje commented Mar 19, 2019

Tracked in JIRA as https://tickets.puppetlabs.com/browse/PDK-1308

@scotje scotje mentioned this issue Mar 19, 2019
Merged
@scotje
Copy link
Contributor

scotje commented Mar 22, 2019

Resolved by #640

@scotje scotje closed this as completed Mar 22, 2019
@ghoneycutt
Copy link
Author

Thanks @scotje and @rodjek

@rodjek rodjek removed the feature label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JIRA JIRA Ticket Created
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scotje @rodjek @ghoneycutt