Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows + hiDPI #1957

Closed
DarkFenX opened this issue Apr 27, 2019 · 4 comments
Closed

Windows + hiDPI #1957

DarkFenX opened this issue Apr 27, 2019 · 4 comments
Labels
bug Confirmed to be a bug duplicate Duplicate of another issue, will most likely be closed with a link to the original gui Issue is related specifically to the GUI code (wxPython)

Comments

@DarkFenX
Copy link
Member

On my 3840x2160 screen it looks like scaled up version of 1920x1080. Need to check if wx can handle scaling on windows by itself and add announce "DPI" support in the manifest.
@DarkFenX DarkFenX added bug Confirmed to be a bug gui Issue is related specifically to the GUI code (wxPython) labels Apr 27, 2019
@DarkFenX
Copy link
Member Author

DarkFenX commented Apr 27, 2019 •
edited
Loading

Some info which might be useful: cztomczak/cefpython#399
edit: nvm, looks like it's CEF-specific

@DarkFenX
Copy link
Member Author

https://wxpython.org/Phoenix/docs/html/wx.Window.html#wx.Window.GetContentScaleFactor

@DarkFenX
Copy link
Member Author

DarkFenX commented May 1, 2019

I tried to enable DPI awareness flag in manifest and pyfa is barely usable in this case. We hardcoded sizes almost everywhere, to properly support scaling we have to rework that into scaled sizes (and deal with shitton of bugs too i guess).

That's alot of work, so I'm postponing it unless someone else does that.

@DarkFenX
Copy link
Member Author

Duplicate of #1225

@DarkFenX DarkFenX marked this as a duplicate of #1225 Aug 12, 2019
@DarkFenX DarkFenX added the duplicate Duplicate of another issue, will most likely be closed with a link to the original label Aug 12, 2019
@DarkFenX DarkFenX mentioned this issue Aug 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed to be a bug duplicate Duplicate of another issue, will most likely be closed with a link to the original gui Issue is related specifically to the GUI code (wxPython)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DarkFenX