Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KazooClient hosts list should accept a list of multiple endpoints #411

Closed
jeffwidman opened this issue Oct 25, 2016 · 2 comments
Closed

Comments

@jeffwidman
Copy link
Member

jeffwidman commented Oct 25, 2016

Currently KazooClient accepts a list of multiple hosts as a single concatenated string: http://kazoo.readthedocs.io/en/latest/api/client.html#kazoo.client.KazooClient

It seems the API would be more pythonic if it also accepted the hosts as a native list:

['zk01:2181', 'zk02:2181', 'zk03:2181']

I can submit a PR for this, but only if I get confirmation the core team is open to this feature request.

See also DataDog/dd-agent#2943 (comment) - for example, KafkaClient supports both the concatenated string and native list formats.

@harlowja
Copy link
Contributor

harlowja commented Dec 3, 2016

Seems fair to me.

@eribeiro
Copy link
Contributor

Hello folks,
I have just submitted a PR to address this issue (my first contribution to Kazoo). See if it fits your needs.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants