Make Travis CI (and Windows x64 ?) mandatory #365
Comments
vstinner
changed the title
|
I can make the change. Which CI should be required, and is this the same for all branches? 3.5, 3.6, 3.7, 3.8? |
|
These are the availble CIs which I can make as "Required". Just let me know which ones we need, then i'll activate them: Azure Pipelines CI |
|
It would be nice to have a least one Linux mandatory CI and one Windows mandatory CI:
It can be the same on 3.7, 3.8 and master branches. -- For 3.5 and 3.6, only Travis CI should be mandatory. I don't think that we have GH actions on the 3.5 branch. Example on my 3.5 PR: python/cpython#19305 there is only Travis CI there. Same for 3.6: I only see Travis CI on this 3.6 PR: python/cpython#19224 |
|
In your list, I'm talking about:
|
|
It's done. |
|
Great, thank you! |
|
Unfortunately, you can't make the GitHub Actions checks required, because GitHub can't tell the difference between when they are excluded by path filters (see python/cpython#19806) I'm pinging my contacts there again, but we're going to have to only require Linux tests for now. |
|
(FWIW, @Mariatta, since you weren't involved in the other discussions, there isn't anyone else supportive of this change that I'm aware of - it's only Victor. But since he's not going to stop his campaign against network flakiness, I'll concede - but NOT in a way that prevents people from merging doc-only changes!) |
|
Me:
Oh right, now I recall the issue :-/ https://bugs.python.org/issue39837#msg363405 |
I moved the discussion to the Core Workflow category of Discourse: -- @Mariatta: Sorry, would you mind to make the Windows (64 bit) job non-voting again, until https://discuss.python.org/t/make-one-windows-ci-job-mandatory/4047 issue is resolved? |
|
Windows(64) has been made not required. |
Thanks again. |
|
I fixed the Windows job of GitHub Action and proposed #368 to make it mandatory. |
|
FYI, I created a PR that updates only the ACKS file, and the required Travis CI never starts: |
Happens sometimes. It could be something wrong on either GitHub or Travis CI's side. Usually I just close and re-open the PR to retrigger the check. |
|
I did try it twice, but I can keep trying. |
I see that python/cpython#20105 is merged so it seems like the problem is gone :-) I hope that the issue is now resolved. |
|
If someone wants to investigate, https://travis-ci.org/python/cpython/builds gives the list of all Travis CI jobs of the CPython project. |
|
Both WIndows x64 and Travis are currently required, so closing. |
Azure Pipelines CI was made optional by @brettcannon: https://bugs.python.org/issue39837
Problem: now, there is no more mandatory CI on Python pull requests. It became possible to merge a PR even if all CIs fail.
I would prefer to also have the Windows 64-bit CI (GitHub Action) mandatory, but I'm not sure if it's possible to only make a single GitHub Action mandatory?
The text was updated successfully, but these errors were encountered: