Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?] hotkey does not work after search #44

Closed
wzajchow opened this issue Feb 25, 2022 · 15 comments
Closed

[Bug?] hotkey does not work after search #44

wzajchow opened this issue Feb 25, 2022 · 15 comments

Comments

@wzajchow
Copy link

By clicking a card in a card view I would like to open this note and close the search view. Currently, it opens the note in the background, but the search view remains on top of it.

@qawatake
Copy link
Owner

@wzajchow

That may be a bug.
Could you retry after disabling all the other plugins?
And please share

  1. screen recording,
  2. debug info. (You can get it by executing Show debug info command.)

@wzajchow
Copy link
Author

Recording

SYSTEM INFO:
	Obsidian version: v0.13.23
	Installer version: v0.12.19
	Operating system: Windows 10 Pro 10.0.19044
	Login status: logged in
	Catalyst license: none
	Insider build toggle: off
	Live preview: on
	Legacy editor: off
	Base theme: light
	Community theme: Atom
	Snippets enabled: 0
	Safe mode: off
	Plugins installed: 27
	Plugins enabled: 1
		1: Core Search Assistant

RECOMMENDATIONS:
	Custom theme: for cosmetic issues, please first try updating your theme to latest. If still not fixed, please try to make the issue happen in the help vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the help vault or disable community plugins.

Clicking on the search results doesn't work either if the search preview is enabled.
I have also noticed that after I do a search, global shortcuts for command palette and quick switcher will stop work.

This may be a specific bug for my environment. I am trying to narrow down the issue but no success.

@qawatake
Copy link
Owner

@wzajchow

Thanks!
Hmm, I could not reproduce the bug with Atom theme.
Could you check and share the output of the console (by pressing Ctrl + Shift + I)?

And if possible, could you retry in a newly created vault?

@wzajchow
Copy link
Author

New vault (only 3 test files, all default settings, live preview enabled, Core Search Assistant enabled with default settings). Unfortunately, the same bad behavior but only after doing 1 or 2 searches. At the very beginning all works great.

SYSTEM INFO:
	Obsidian version: v0.13.23
	Installer version: v0.12.19
	Operating system: Windows 10 Pro 10.0.19044
	Login status: logged in
	Catalyst license: none
	Insider build toggle: off
	Live preview: on
	Legacy editor: off
	Base theme: dark
	Community theme: none
	Snippets enabled: 0
	Safe mode: off
	Plugins installed: 1
	Plugins enabled: 1
		1: Core Search Assistant

RECOMMENDATIONS:
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the help vault or disable community plugins.

Console output is empty
image

I actually tried on 2 PCs and I have same results. The second one is almost clean Windows install. No idea what should I test to find the problem and if it's related to obsidian/plugin/OS.

@wzajchow
Copy link
Author

I made a few tests and problem with global shortcut Ctrl+P and Ctrl+O appears only after I enable Core Search Assistant plugin.

@qawatake
Copy link
Owner

@wzajchow

I also have the same problem, but only rarely. So I'm having a hard time reproducing this bug.

Could you tell me the complete list of your actions reproducing the bug?

  • the order of actions,
  • how to search (by clicking or by hotkey),
  • how to select the search result (by clicking or by by keyboard).
  • ...

@qawatake qawatake changed the title [Feature Request] Clicking on cards opens the note [Bug?] hotkey does not work after search Feb 27, 2022
@wzajchow
Copy link
Author

To reproduce the issue.

  1. Open Obsidian
  2. Try ctrl+P/ctrl+O - it works
  3. Try search
  4. Again ctrl+P/ctrl+O - it works
  5. Enable Core Serach plugin
  6. ctrl+P/ctrl+O - it works
  7. Try Search - clicking on notes doesn't work
  8. ctrl+P/ctrl+O - it doesn't work anymore

Video

@qawatake
Copy link
Owner

@wzajchow
Hmm, I'm sorry, but I haven't found a way to reproduce the bug.
Could you try one of the followings?

  • Release 0.7.0
    • You must manually install it.
  • Enable option Render cards manually.

@wzajchow
Copy link
Author

wzajchow commented Feb 28, 2022

With 0.7.0 installed and Render cards manually enabled everything works perfect. No issues with hotkeys and clicking on cards open the note.
I will test with other plugins enabled.

@wzajchow
Copy link
Author

wzajchow commented Mar 1, 2022

Works with other plugins enabled too.
As soon as I disable Render cards manually clicking on cards and global shortcut won't work anymore (Obsidian restart is necessary).

@qawatake
Copy link
Owner

qawatake commented Mar 1, 2022

@wzajchow

Thanks.
What happens if I enable Render cards manually in the latest release?

@wzajchow
Copy link
Author

wzajchow commented Mar 1, 2022

@qawatake
It works fine. No issues observed

@qawatake
Copy link
Owner

qawatake commented Mar 1, 2022

@qawatake

Thank you for checking!
I'll add the workaround to README.md.

@qawatake qawatake closed this as completed Mar 1, 2022
@scpedicini
Copy link

I'm aware this issue is closed, but core-search also has a tendency to break all my global hotkeys (especially if I use the search which shows the cards, but then escape or don't select one of them).

Only a full restart of Obsidian fixes it.

@MariosGkMeng
Copy link

wzajchow

Today I also had issues with my hotkeys (none would work).

Somehow it got fixed by disabling the community plugins, closing Obsidian and re-opening it 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants