-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl::has_internet() breaks for those who work behind a proxy #150
Comments
Thanks, for bringing this up. Do you think it is still the case after this fix jeroen/curl@6fc0305 in |
If the fix is |
Hi I was away from the corporate proxy so couldn't text these over the weekend. Unfortunately both the update to curl and the original leave the same outcome: |
OK, I've done some digging. If you like I can submit a pull request with the changes. I describe the process below. First, after looking deeper into the issue, My usage of On Windows, unless otherwise configured From what I can tell, that my workplace allows Internet Explorer to access the internet, but does not allow RStudio to, without recourse to proxy information. My solution is to remove the If a function is needed to check if the internet is available via
|
Doing some testing now. If @muuankarski has any comments that might help. |
Ok, had a look at this using However, we need to comply with CRAN policy...
...and need a way to prevent error when resource is not available, I was not able to produce
Although I can't reproduce the behaviour, I agree that we should find an replacement for
Any ideas? |
I am a ignorant on network setup. Hence, I cannot comment on, if I think it will work. |
@JensXII perhaps you can run the lines below and report if it works for you?
In unix, behind a proxy with no proxy defined, this should gracefully fail and produce a message
|
Hi I finally got around to looking. This fix fixes behind the firewall for our uses. Thanks a lot for taking care. |
If it's pulled into master we can close the issue. Thanks. |
I have done the testing suggested by muuankarski, but changed to get_eurostat to what caused me problem in the first place. Hence, I agree, get the cran-package updated, and close the issue. Thank you, for the quick solving of the problem :-)
A tibble: 10 x 8title code type
trying URL 'https://ec.europa.eu/eurostat/estat-navtree-portlet-prod/BulkDownloadListing?sort=1&file=data%2Fdemo_r_pjangrp3.tsv.gz' Table demo_r_pjangrp3 cached at C:\Users\NLS\AppData\Local\Temp\4\RtmpA3HIko/eurostat/demo_r_pjangrp3_num_code_TF.rds
1: All Enter one or more numbers, or an empty line to skip updates: trying URL 'https://cran.rstudio.com/bin/windows/contrib/3.5/hms_0.5.3.zip' package ‘tidyr’ successfully unpacked and MD5 sums checked The downloaded binary packages are in
A tibble: 10 x 8title code type
Table demo_r_frate2 cached at C:\Users\nls\AppData\Local\Temp\RtmpcbV1oF/eurostat/demo_r_frate2_date_code_TF.rds A tibble: 431,470 x 5unit age geo time values ... with 431,460 more rows
trying URL 'https://ec.europa.eu/eurostat/estat-navtree-portlet-prod/BulkDownloadListing?sort=1&file=data%2Fdemo_r_pjangrp3.tsv.gz' Table demo_r_pjangrp3 cached at C:\Users\nls\AppData\Local\Temp\RtmpcbV1oF/eurostat/demo_r_pjangrp3_num_code_TF.rds |
@muuankarski when you are ready, can you merge to devel branch; I can take care of the rest of testing, CRAN, and master then. |
merged in to devel |
Fixed in master now & on the way to CRAN. |
I left a comment on the commit also:
19a22f3#commitcomment-36824920
Perhaps first check if has_internet and if not, if http_proxy is defined?
The text was updated successfully, but these errors were encountered: