-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable conda-build
to produce .conda
packages
#176
base: main
Are you sure you want to change the base?
Conversation
Switch from `.tar.bz2` packages to `.conda` packages. This will allow the metadata of packages to be read without decompression. Also `.conda` packages allow changing the compression used under-the-hood (currently this is Zstd based).
Nearly all jobs passed. One failed due to a network error (snippet below)
Restarted the failed job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support this!
But note there will need to also be some changes to CI tools / scripts which are currently listing files via wildcards like *.tar.bz2
.
search: https://github.com/search?q=org%3Arapidsai+%22tar.bz2%22&type=code&p=2
examples:
- https://github.com/rapidsai/gha-tools/blob/2b3d27e693e3bb96802023a7de4ab477597b1135/tools/rapids-find-anaconda-uploads.py#L67
- https://github.com/rapidsai/dependency-file-generator/blob/4e32ded33b3df70e88cff06bac59488fca74ae7f/ci/publish/conda.sh#L12
- https://github.com/rapidsai/cugraph-pg/blob/d0d101a53c89984841199c3555bde6ee5d8658be/ci/build_docs.sh#L40
Adding There are a list of xref'd PRs below James' other comment: rapidsai/build-planning#98 (comment) Perhaps folks can review these as they are able |
Thanks! I just reviewed all of those and did one more GitHub search (link). I think you got all the cases, so once those open PRs are merged (at least the ones in the active repos), I think this PR here in |
Thanks James! 🙏 Appreciate you going through those so quickly. Please let me know if I've missed any feedback that needs addressing Am noticing the label checker is not enabled here. So the To avoid accidental merges before those other items are addressed, will mark this as draft. We can mark it ready for review after |
Think we have cleared all the requirements for this change Would propose that we add this after 24.10 ships. So leaving as draft for now Though think we should do this at the start of 24.12 so we have more time to get comfortable with this change |
Fixes rapidsai/build-planning#98
Switch from
.tar.bz2
packages to.conda
packages. This will allow the metadata of packages to be read without decompression. Also.conda
packages allow changing the compression used under-the-hood (currently this is Zstd based).