Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around scikit-build include_package_data bug in legate/setup.py #233

Closed
wence- opened this issue Jun 6, 2023 · 1 comment
Closed

Work around scikit-build include_package_data bug in legate/setup.py #233

wence- opened this issue Jun 6, 2023 · 1 comment

Comments

@wence-
Copy link
Contributor

wence- commented Jun 6, 2023

Not critical since kvikio doesn't have wheels, but scikit-build has bugs with include_package_data so specifying package_data explicitly (like in the non-legate setup.py) is safer. That said I don't see wheels happening for legate-kvikio anytime soon so it's mostly just to be safe.

Originally posted by @vyasr in #232 (comment)
@wence- wence- mentioned this issue Jun 6, 2023
Merged
@jakirkham jakirkham mentioned this issue Jun 28, 2023
Closed
@madsbk
Copy link
Member

madsbk commented Jul 25, 2024

legate/setup.py has been removed

@madsbk madsbk closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@madsbk @wence-