From efe3a48a5e456123c7ef82140dfef5e9197d30e8 Mon Sep 17 00:00:00 2001 From: Matthew Murray Date: Wed, 25 Sep 2024 07:57:19 -0700 Subject: [PATCH] address review --- python/rmm/rmm/__init__.py | 5 ----- python/rmm/rmm/_lib/__init__.py | 7 ------- python/rmm/rmm/tests/test_rmm.py | 6 ------ 3 files changed, 18 deletions(-) diff --git a/python/rmm/rmm/__init__.py b/python/rmm/rmm/__init__.py index c52818a75..b23ad68f9 100644 --- a/python/rmm/rmm/__init__.py +++ b/python/rmm/rmm/__init__.py @@ -57,12 +57,7 @@ def __getattr__(name): if name == "_lib": import importlib - import warnings - warnings.warn( - "The `rmm._lib` module is deprecated in will be removed in a future release. Use `rmm.pylibrmm` instead.", - FutureWarning, - ) module = importlib.import_module("rmm.pylibrmm") return module else: diff --git a/python/rmm/rmm/_lib/__init__.py b/python/rmm/rmm/_lib/__init__.py index 965d8e917..7cfddab60 100644 --- a/python/rmm/rmm/_lib/__init__.py +++ b/python/rmm/rmm/_lib/__init__.py @@ -12,11 +12,4 @@ # See the License for the specific language governing permissions and # limitations under the License. -import warnings - -warnings.warn( - "The `rmm._lib` module is deprecated in will be removed in a future release. Use `rmm.pylibrmm` instead.", - FutureWarning, -) - from rmm.pylibrmm import * diff --git a/python/rmm/rmm/tests/test_rmm.py b/python/rmm/rmm/tests/test_rmm.py index 7704cac25..c03b9e501 100644 --- a/python/rmm/rmm/tests/test_rmm.py +++ b/python/rmm/rmm/tests/test_rmm.py @@ -1076,9 +1076,3 @@ def test_available_device_memory(): assert initial_memory[1] == final_memory[1] assert initial_memory[0] > 0 assert final_memory[0] > 0 - - -# TODO: Remove test when rmm._lib is removed in 24.12 -def test_deprecate_rmm_lib(): - with pytest.warns(FutureWarning): - rmm._lib.device_buffer.DeviceBuffer(size=100)