Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jm/keybinds #11

Merged
merged 2 commits into from
Feb 9, 2024
Merged

jm/keybinds #11

merged 2 commits into from
Feb 9, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented Feb 9, 2024

  • feat: simplify key binding config
  • feat: simplify key bindings for tab switching

- Use Tab / Shift-Tab to switch between tabs
- Change sort key binding to ctrl-s / ctrl-S
- Add NextTab and PreviousTab actions to switch
  between tabs
- Add Common mode to handle common key bindings
- Change filter key binding to f
- Make Up/Down/Left/Right/Home/End consistent
- Remove direct mode switching key bindings (e.g.
  '[' to switch to summary mode, / to switch to
  search mode, etc.)
@joshka joshka requested a review from kdheepak February 9, 2024 06:00
@joshka
Copy link
Member Author

joshka commented Feb 9, 2024

These keybinds came about from just naturally using the app and pressing buttons that seemed like the logical things that should work:

  • Tab to change tabs
  • left, right, up, down on the summary page

Moving the crate info to its own tab and decoupling it from the list would simplify the picker keybinds to single section and remove the need for mode switching

Making filter and search submodes of the search page instead of modes of the app would help simplify this too

@kdheepak kdheepak merged commit cf1f3d2 into main Feb 9, 2024
1 check failed
@kdheepak kdheepak deleted the jm/keybinds branch February 9, 2024 07:08
@kdheepak kdheepak mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants