Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support chunked transfer encoding #96

Closed
clue opened this issue Feb 8, 2017 · 4 comments · Fixed by #116
Closed

Support chunked transfer encoding #96

clue opened this issue Feb 8, 2017 · 4 comments · Fixed by #116

Comments

@clue
Copy link
Member

clue commented Feb 8, 2017

See https://tools.ietf.org/html/rfc7230#section-3.3.1 and https://tools.ietf.org/html/rfc7230#section-3.3

@WyriHaximus
Copy link
Member

FYI we support it from our side to the client but not the other way around yet: https://github.com/reactphp/http/blob/master/src/Response.php#L99-L105

@clue
Copy link
Member Author

clue commented Feb 8, 2017

Thanks for linking to this, FWIW, this has been implemented in the HttpClient component via reactphp/http-client#58

@clue
Copy link
Member Author

clue commented Feb 8, 2017

I hear @legionth may be working on this feature currently, perhaps he can chime in here? 😀

@legionth
Copy link
Contributor

legionth commented Feb 8, 2017

Yes, I'm currently working on this. Because the client and server component are currently seperated (and I think this won't change in the next days), I would consider to put a chunked encoder and decoder into this package. Even if this would lead to a duplication.

I will check if this reactphp/http-client#58 or this https://github.com/legionth/php-http-server-react/blob/master/src/ChunkedDecoder.php is better to use in my current work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants