From 6edf0364bcbb6197ec0b515580326899b3b41e53 Mon Sep 17 00:00:00 2001
From: Pedro Cattori <pcattori@gmail.com>
Date: Tue, 17 Sep 2024 21:33:11 -0400
Subject: [PATCH] fix single-fetch types for functions that return unions

Co-authored-by: Michael McDermott <michael.g.mcdermott@gmail.com>
---
 .changeset/many-donuts-tie.md                 |  5 +++
 packages/remix-server-runtime/single-fetch.ts | 39 ++++++++++++++-----
 2 files changed, 34 insertions(+), 10 deletions(-)
 create mode 100644 .changeset/many-donuts-tie.md

diff --git a/.changeset/many-donuts-tie.md b/.changeset/many-donuts-tie.md
new file mode 100644
index 00000000000..06923bfd878
--- /dev/null
+++ b/.changeset/many-donuts-tie.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/server-runtime": patch
+---
+
+Fix single-fetch types when `loader`, `action`, `clientLoader`, or `clientAction` return a mixture of bare objects, `json(...)`, `defer(...)`, and `unstable_data(...)`.
diff --git a/packages/remix-server-runtime/single-fetch.ts b/packages/remix-server-runtime/single-fetch.ts
index 222f74bb4e2..046201a0ea9 100644
--- a/packages/remix-server-runtime/single-fetch.ts
+++ b/packages/remix-server-runtime/single-fetch.ts
@@ -418,6 +418,19 @@ type Serialize<T> =
 
   undefined
 
+// prettier-ignore
+type ClientData<T> =
+  T extends TypedResponse<infer U> ? Jsonify<U> :
+  T extends TypedDeferredData<infer U> ? U :
+  T
+
+// prettier-ignore
+type ServerData<T> =
+  T extends TypedResponse<infer U> ? Jsonify<U> :
+  T extends TypedDeferredData<infer U> ? Serialize<U> :
+  T extends DataWithResponseInit<infer U> ? Serialize<U> :
+  Serialize<T>
+
 // Backwards-compatible type for Remix v2 where json/defer still use the old types,
 // and only non-json/defer returns use the new types.  This allows for incremental
 // migration of loaders to return naked objects.  In the next major version,
@@ -425,15 +438,8 @@ type Serialize<T> =
 // prettier-ignore
 export type SerializeFrom<T> =
   T extends (...args: infer Args) => infer Return ?
-    Args extends [ClientLoaderFunctionArgs | ClientActionFunctionArgs] ?
-      Awaited<Return> extends TypedResponse<infer U> ? Jsonify<U> :
-      Awaited<Return> extends TypedDeferredData<infer U> ? U :
-      Awaited<Return>
-    :
-    Awaited<Return> extends TypedResponse<infer U> ? Jsonify<U> :
-    Awaited<Return> extends TypedDeferredData<infer U> ? Serialize<U> :
-    Awaited<Return> extends DataWithResponseInit<infer D> ? Serialize<D> :
-    Serialize<Awaited<ReturnType<T>>>
+    Args extends [ClientLoaderFunctionArgs | ClientActionFunctionArgs] ? ClientData<Awaited<Return>> :
+    ServerData<Awaited<Return>>
   :
   T
 
@@ -607,5 +613,18 @@ type _tests = [
   Expect<Equal<Pretty<SerializeFrom<ServerLoader<TypedDeferredData<{a: string, b: Promise<Date>}>>>>, { a: string, b: Promise<Date> }>>,
 
   // non-function backcompat
-  Expect<Equal<SerializeFrom<{a: string, b: Date}>, {a: string, b: Date}>>
+  Expect<Equal<SerializeFrom<{a: string, b: Date}>, {a: string, b: Date}>>,
+
+  Expect<Equal<
+    SerializeFrom<ServerLoader<
+    | { a: string; b: Date }
+    | TypedResponse<{ c: string; d: Date }>
+    | TypedDeferredData<{ e: string; f: Promise<Date> }>
+    | DataWithResponseInit<{ g: string; h: Date }>
+    >>,
+    | { a: string; b: Date }
+    | Jsonify<{ c: string; d: Date }>
+    | { e: string; f: Promise<Date> }
+    | { g: string; h: Date }
+  >>,
 ]