From 81b4e60755db5659971b5194a1c1e7a863969592 Mon Sep 17 00:00:00 2001 From: Ralph Castain Date: Sat, 18 Nov 2023 12:37:44 -0700 Subject: [PATCH] Fix handling of "--" in cmd line Allow the app parser to see the line and rely on the PMIx cmd line parser to handle it. Signed-off-by: Ralph Castain --- src/prted/prte_app_parse.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/src/prted/prte_app_parse.c b/src/prted/prte_app_parse.c index 7d5834e3e6..29b015613d 100644 --- a/src/prted/prte_app_parse.c +++ b/src/prted/prte_app_parse.c @@ -336,7 +336,6 @@ int prte_parse_locals(prte_schizo_base_module_t *schizo, char **temp_argv, **env; prte_pmix_app_t *app; bool made_app; - bool ddash = false; /* Make the apps */ temp_argv = NULL; @@ -348,13 +347,6 @@ int prte_parse_locals(prte_schizo_base_module_t *schizo, env = NULL; for (i = 1; NULL != argv[i]; ++i) { - // if this is a `--`, then everything beyond it - // belongs to the application - if (0 == strcmp(argv[i], "--")) { - ddash = true; - ++i; - break; - } if (0 == strcmp(argv[i], ":")) { /* Make an app with this argv */ if (PMIX_ARGV_COUNT_COMPAT(temp_argv) > 1) { @@ -394,13 +386,9 @@ int prte_parse_locals(prte_schizo_base_module_t *schizo, } if (made_app) { pmix_list_append(jdata, &app->super); - if (ddash && NULL != argv[i]) { - for (j=i; NULL != argv[j]; j++) { - PMIX_ARGV_APPEND_NOSIZE_COMPAT(&app->app.argv, argv[j]); - } - } } } + if (NULL != env) { PMIX_ARGV_FREE_COMPAT(env); }