-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataDog APM not receiving data #4952
Comments
Hey @layerssss, thanks for reporting this issue. I see you spotted the difference in the Judging by the diff in that PR, it looks like you could set the Service back to trace_with GraphQL::Tracing::DataDogTrace, service: "ruby-graphql" What happens if you add that option to your setup? |
Hi @rmosolgo I think you are right, the data is sent to DataDog under the new service name Adding |
cc @TonyCTHsu @vpellan is this intended behavior? Should the GraphQL-Ruby plugin still be providing |
👋 @layerssss @rmosolgo Thanks for reporting.
Generally speaking, it is your application. Historically, it was abused for other reasons. Assigning it incorrectly would break other features such as Service Catalog. GraphQL should be considered as internal to your application without explicitly defining it as a different service other than your application. The service for GraphQL spans will be labelled as your service definition from your configuration. Datadog.configure do |c|
c.service = "..."
end I would highly recommend to NOT provide the default service |
@TonyCTHsu Thanks for referring to the documentation. But if I remove the It's not inside the |
@TonyCTHsu I've tried setting a default Now the whole configuration becomes:
(we have 2 schemas) I've also removed This does result all integrations ended up nicely under the new "service" ( When I changed |
Hey @layerssss, is there any information in the |
In In |
@layerssss, glad to hear that using @marcotc or @TonyCTHsu, can either of you provide a screenshot of how GraphQL data should look in the DataDog UI? I want to make sure our default plugin makes data appear somewhere, because as @layerssss mentioned, it contains information that other spans don't have. |
I don't know what else needs to happen in GraphQL-Ruby here, so I'll close this out. |
Describe the bug
I was tracking an issue after upgrading
ruby-graphql
the DataDog APM stopped receiving data. I found this issue occurred in version 2.1.11, as well as 2.2.24, 2.3.3. (working well in in <= 2.1.10)I noticed when it was working well (2.2.10), I could get these log by
DD_TRACE_DEBUG=true
But in 2.2.11 (when APM is no longer receiving data)
I could see the difference in
Service:
changed fromruby-graphql
torails
, so wondered if this patch made in 2.1.10 had potentially broken it. @TonyCTHsuVersions
graphql
version: 2.1.11Steps to reproduce
Expected behavior
Expect data entries to popup in DataDog
ruby-graphql
APM.Actual behavior
No data arrives in DataDog
ruby-graphql
APMAdditional context
The way we configure DataDog:
We have a secondary GraphQL schema also with
use(GraphQL::Tracing::DataDogTracing)
.Switching to the new
trace_with GraphQL::Tracing::DataDogTrace
after upgrading didn't solve the issue.Switching to
ddtrace
2.x (datadog
) didn't solve the issue either.The text was updated successfully, but these errors were encountered: