Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] component node main runs empty node if class is not found #2414

Closed
Aposhian opened this issue Jan 25, 2024 · 0 comments · Fixed by #2415
Closed

[BUG] component node main runs empty node if class is not found #2414

Aposhian opened this issue Jan 25, 2024 · 0 comments · Fixed by #2415
Assignees

Comments

@Aposhian
Copy link
Contributor

Bug report

Required Info:

  • Operating System:
    • Ubuntu 22.04
  • Installation type:
    • binaries
  • Version or commit hash:
    • 16.0.7-1jammy.20231205.162058
  • DDS implementation:
    • CycloneDDS
  • Client library (if applicable):
    • rclcpp

Steps to reproduce issue

  1. Create a shared library with no nodes in it and compile
  2. Create a rclcpp::Node class and register it as a component. Put it in a new version of the shared library.
  3. In the install workspace, replace the new shared library with the old .so
  4. Run the generated rclcpp_components main executable.

Expected behavior

Node to throw exception and crash.

Actual behavior

Executor starts running but with no node inside, and just hangs on waiting for work forever.

Additional information

Theoretically this state shouldn't happen, but it did for me because of cached .so binaries that didn't have the class inside. This should be a fairly simple fix: just crash if no matching classes were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants