Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate the documentation of is_match #711

Closed
wants to merge 2 commits into from

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Oct 5, 2020

This may be subjective, and due to the fact that I am not a native speaker, but I initially understood

the regex matches the string given.

as meaning that the match for the regex should span the entire given string.

I changed it to

there is a match for the regex in the string given.

which in unambiguous.

BurntSushi pushed a commit that referenced this pull request Oct 11, 2020
This makes it a bit clearer that `is_match` does not require the match
to span the entire string, but rather, that a match may occur anywhere
in the string.

Closes #711
@lovasoa lovasoa deleted the patch-1 branch October 12, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant