Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Massive clippy breakage incoming #2785

Closed
oli-obk opened this issue May 21, 2018 · 4 comments
Closed

Massive clippy breakage incoming #2785

oli-obk opened this issue May 21, 2018 · 4 comments
Labels
T-macros Type: Issues with macros and macro expansion

Comments

@oli-obk
Copy link
Contributor

oli-obk commented May 21, 2018

When rust-lang/rust#50050 (comment) is implemented, we lose all ability to detect macro expansions.

No ETA on getting them back, but there's a plan outlined in the link above.
@phansch phansch added the T-macros Type: Issues with macros and macro expansion label May 23, 2018
@phansch
Copy link
Member

phansch commented May 24, 2018 •
edited
Loading

Won't that also break some rustc lints?

Once that's on nightly, we should probably put the last working nightly/clippy version combination at the top of the readme, as #2705 suggests.

@phansch
Copy link
Member

phansch commented Jul 17, 2018

@oli-obk I think this will be fully fixed by using in_external_macro from rust-lang/rust#52467, right?

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 17, 2018

Probably. I think we'll see some changes in tests

@phansch
Copy link
Member

phansch commented Dec 13, 2018

IIRC this breakage didn't turn out too bad, so I'm going to close this issue.

@phansch phansch closed this as completed Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-macros Type: Issues with macros and macro expansion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oli-obk @phansch