From 226bcdf7d1e774f5967f92b0bd0bf237179f95c9 Mon Sep 17 00:00:00 2001 From: Wangshan Lu Date: Sun, 22 May 2016 22:36:55 +0800 Subject: [PATCH 1/2] Rename main thread from "
" to "main". Fix issue #33789 --- src/doc/book/advanced-linking.md | 2 +- src/doc/book/error-handling.md | 4 ++-- src/doc/book/functions.md | 8 ++++---- src/doc/book/guessing-game.md | 2 +- src/doc/book/strings.md | 2 +- src/doc/book/testing.md | 2 +- src/doc/book/vectors.md | 2 +- src/libstd/rt.rs | 2 +- src/test/run-fail/main-panic.rs | 2 +- src/test/run-fail/overflowing-add.rs | 2 +- src/test/run-fail/overflowing-lsh-1.rs | 2 +- src/test/run-fail/overflowing-lsh-2.rs | 2 +- src/test/run-fail/overflowing-lsh-3.rs | 2 +- src/test/run-fail/overflowing-lsh-4.rs | 2 +- src/test/run-fail/overflowing-mul.rs | 2 +- src/test/run-fail/overflowing-neg.rs | 2 +- src/test/run-fail/overflowing-pow.rs | 2 +- src/test/run-fail/overflowing-rsh-1.rs | 2 +- src/test/run-fail/overflowing-rsh-2.rs | 2 +- src/test/run-fail/overflowing-rsh-3.rs | 2 +- src/test/run-fail/overflowing-rsh-4.rs | 2 +- src/test/run-fail/overflowing-rsh-5.rs | 2 +- src/test/run-fail/overflowing-rsh-6.rs | 2 +- src/test/run-fail/overflowing-sub.rs | 2 +- src/test/run-fail/panic-set-unset-handler.rs | 2 +- src/test/run-fail/panic-take-handler-nop.rs | 2 +- src/test/run-pass/multi-panic.rs | 2 +- 27 files changed, 31 insertions(+), 31 deletions(-) diff --git a/src/doc/book/advanced-linking.md b/src/doc/book/advanced-linking.md index c8a9082947eea..ddaebaf98d99d 100644 --- a/src/doc/book/advanced-linking.md +++ b/src/doc/book/advanced-linking.md @@ -134,7 +134,7 @@ $ ldd example not a dynamic executable $ ./example hi! -thread '
' panicked at 'failed', example.rs:1 +thread 'main' panicked at 'failed', example.rs:1 ``` Success! This binary can be copied to almost any Linux machine with the same diff --git a/src/doc/book/error-handling.md b/src/doc/book/error-handling.md index c914c33a5a4b9..ab226d5adc374 100644 --- a/src/doc/book/error-handling.md +++ b/src/doc/book/error-handling.md @@ -81,7 +81,7 @@ fn main() { If you try running this code, the program will crash with a message like this: ```text -thread '
' panicked at 'Invalid number: 11', src/bin/panic-simple.rs:5 +thread 'main' panicked at 'Invalid number: 11', src/bin/panic-simple.rs:5 ``` Here's another example that is slightly less contrived. A program that accepts @@ -498,7 +498,7 @@ At this point, you should be skeptical of calling `unwrap`. For example, if the string doesn't parse as a number, you'll get a panic: ```text -thread '
' panicked at 'called `Result::unwrap()` on an `Err` value: ParseIntError { kind: InvalidDigit }', /home/rustbuild/src/rust-buildbot/slave/beta-dist-rustc-linux/build/src/libcore/result.rs:729 +thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ParseIntError { kind: InvalidDigit }', /home/rustbuild/src/rust-buildbot/slave/beta-dist-rustc-linux/build/src/libcore/result.rs:729 ``` This is rather unsightly, and if this happened inside a library you're diff --git a/src/doc/book/functions.md b/src/doc/book/functions.md index 3a10d2aecc25e..574929c14b35d 100644 --- a/src/doc/book/functions.md +++ b/src/doc/book/functions.md @@ -221,7 +221,7 @@ If you add a main function that calls `diverges()` and run it, you’ll get some output that looks like this: ```text -thread ‘
’ panicked at ‘This function never returns!’, hello.rs:2 +thread ‘main’ panicked at ‘This function never returns!’, hello.rs:2 ``` If you want more information, you can get a backtrace by setting the @@ -229,7 +229,7 @@ If you want more information, you can get a backtrace by setting the ```text $ RUST_BACKTRACE=1 ./diverges -thread '
' panicked at 'This function never returns!', hello.rs:2 +thread 'main' panicked at 'This function never returns!', hello.rs:2 stack backtrace: 1: 0x7f402773a829 - sys::backtrace::write::h0942de78b6c02817K8r 2: 0x7f402773d7fc - panicking::on_panic::h3f23f9d0b5f4c91bu9w @@ -255,7 +255,7 @@ Any other value(even no value at all) turns on backtrace. $ export RUST_BACKTRACE=1 ... $ RUST_BACKTRACE=0 ./diverges -thread '
' panicked at 'This function never returns!', hello.rs:2 +thread 'main' panicked at 'This function never returns!', hello.rs:2 note: Run with `RUST_BACKTRACE=1` for a backtrace. ``` @@ -264,7 +264,7 @@ note: Run with `RUST_BACKTRACE=1` for a backtrace. ```text $ RUST_BACKTRACE=1 cargo run Running `target/debug/diverges` -thread '
' panicked at 'This function never returns!', hello.rs:2 +thread 'main' panicked at 'This function never returns!', hello.rs:2 stack backtrace: 1: 0x7f402773a829 - sys::backtrace::write::h0942de78b6c02817K8r 2: 0x7f402773d7fc - panicking::on_panic::h3f23f9d0b5f4c91bu9w diff --git a/src/doc/book/guessing-game.md b/src/doc/book/guessing-game.md index a2067e33a60aa..c759ff9bdbde4 100644 --- a/src/doc/book/guessing-game.md +++ b/src/doc/book/guessing-game.md @@ -806,7 +806,7 @@ You guessed: 59 You win! Please input your guess. quit -thread '
' panicked at 'Please type a number!' +thread 'main' panicked at 'Please type a number!' ``` Ha! `quit` actually quits. As does any other non-number input. Well, this is diff --git a/src/doc/book/strings.md b/src/doc/book/strings.md index 008644ec9a3e2..7be90e785b02b 100644 --- a/src/doc/book/strings.md +++ b/src/doc/book/strings.md @@ -163,7 +163,7 @@ let hachi = &dog[0..2]; with this error: ```text -thread '
' panicked at 'index 0 and/or 2 in `忠犬ハチ公` do not lie on +thread 'main' panicked at 'index 0 and/or 2 in `忠犬ハチ公` do not lie on character boundary' ``` diff --git a/src/doc/book/testing.md b/src/doc/book/testing.md index 4ea114c4bee68..d8afd7c4cf3bf 100644 --- a/src/doc/book/testing.md +++ b/src/doc/book/testing.md @@ -107,7 +107,7 @@ failures: test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured -thread '
' panicked at 'Some tests failed', /home/steve/src/rust/src/libtest/lib.rs:247 +thread 'main' panicked at 'Some tests failed', /home/steve/src/rust/src/libtest/lib.rs:247 ``` Rust indicates that our test failed: diff --git a/src/doc/book/vectors.md b/src/doc/book/vectors.md index 1c44af2f21a71..2fe3225b28d9e 100644 --- a/src/doc/book/vectors.md +++ b/src/doc/book/vectors.md @@ -79,7 +79,7 @@ println!("Item 7 is {}", v[7]); then the current thread will [panic] with a message like this: ```text -thread '
' panicked at 'index out of bounds: the len is 3 but the index is 7' +thread 'main' panicked at 'index out of bounds: the len is 3 but the index is 7' ``` If you want to handle out-of-bounds errors without panicking, you can use diff --git a/src/libstd/rt.rs b/src/libstd/rt.rs index 6eee4ee9bbe5f..15c6c3a98092c 100644 --- a/src/libstd/rt.rs +++ b/src/libstd/rt.rs @@ -51,7 +51,7 @@ fn lang_start(main: *const u8, argc: isize, argv: *const *const u8) -> isize { // created. Note that this isn't necessary in general for new threads, // but we just do this to name the main thread and to give it correct // info about the stack bounds. - let thread: Thread = NewThread::new(Some("
".to_owned())); + let thread: Thread = NewThread::new(Some("main".to_owned())); thread_info::set(main_guard, thread); // Store our args if necessary in a squirreled away location diff --git a/src/test/run-fail/main-panic.rs b/src/test/run-fail/main-panic.rs index b8ff1be71bf2b..87f77681fa02d 100644 --- a/src/test/run-fail/main-panic.rs +++ b/src/test/run-fail/main-panic.rs @@ -8,7 +8,7 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -// error-pattern:thread '
' panicked at +// error-pattern:thread 'main' panicked at fn main() { panic!() diff --git a/src/test/run-fail/overflowing-add.rs b/src/test/run-fail/overflowing-add.rs index c989cc594536b..26cc9eda04634 100644 --- a/src/test/run-fail/overflowing-add.rs +++ b/src/test/run-fail/overflowing-add.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'arithmetic operation overflowed' +// error-pattern:thread 'main' panicked at 'arithmetic operation overflowed' // compile-flags: -C debug-assertions diff --git a/src/test/run-fail/overflowing-lsh-1.rs b/src/test/run-fail/overflowing-lsh-1.rs index a27210112982a..4648f5c9c79d5 100644 --- a/src/test/run-fail/overflowing-lsh-1.rs +++ b/src/test/run-fail/overflowing-lsh-1.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'shift operation overflowed' +// error-pattern:thread 'main' panicked at 'shift operation overflowed' // compile-flags: -C debug-assertions #![warn(exceeding_bitshifts)] diff --git a/src/test/run-fail/overflowing-lsh-2.rs b/src/test/run-fail/overflowing-lsh-2.rs index fe0bcc5b98545..12741864eda9e 100644 --- a/src/test/run-fail/overflowing-lsh-2.rs +++ b/src/test/run-fail/overflowing-lsh-2.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'shift operation overflowed' +// error-pattern:thread 'main' panicked at 'shift operation overflowed' // compile-flags: -C debug-assertions #![warn(exceeding_bitshifts)] diff --git a/src/test/run-fail/overflowing-lsh-3.rs b/src/test/run-fail/overflowing-lsh-3.rs index aac220d32d9ce..76e029bab5219 100644 --- a/src/test/run-fail/overflowing-lsh-3.rs +++ b/src/test/run-fail/overflowing-lsh-3.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'shift operation overflowed' +// error-pattern:thread 'main' panicked at 'shift operation overflowed' // compile-flags: -C debug-assertions #![warn(exceeding_bitshifts)] diff --git a/src/test/run-fail/overflowing-lsh-4.rs b/src/test/run-fail/overflowing-lsh-4.rs index 7e8b266da49be..a9ee4b882532b 100644 --- a/src/test/run-fail/overflowing-lsh-4.rs +++ b/src/test/run-fail/overflowing-lsh-4.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'shift operation overflowed' +// error-pattern:thread 'main' panicked at 'shift operation overflowed' // compile-flags: -C debug-assertions // This function is checking that our automatic truncation does not diff --git a/src/test/run-fail/overflowing-mul.rs b/src/test/run-fail/overflowing-mul.rs index 8cba700bbf9a3..179622e49a628 100644 --- a/src/test/run-fail/overflowing-mul.rs +++ b/src/test/run-fail/overflowing-mul.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'arithmetic operation overflowed' +// error-pattern:thread 'main' panicked at 'arithmetic operation overflowed' // compile-flags: -C debug-assertions #![feature(rustc_attrs)] diff --git a/src/test/run-fail/overflowing-neg.rs b/src/test/run-fail/overflowing-neg.rs index 2d9d746bef324..2bc625f692e53 100644 --- a/src/test/run-fail/overflowing-neg.rs +++ b/src/test/run-fail/overflowing-neg.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'attempted to negate with overflow' +// error-pattern:thread 'main' panicked at 'attempted to negate with overflow' // compile-flags: -C debug-assertions #![feature(rustc_attrs)] diff --git a/src/test/run-fail/overflowing-pow.rs b/src/test/run-fail/overflowing-pow.rs index 15335b8dfb12e..e9fea9e1141ed 100644 --- a/src/test/run-fail/overflowing-pow.rs +++ b/src/test/run-fail/overflowing-pow.rs @@ -8,7 +8,7 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -// error-pattern:thread '
' panicked at 'arithmetic operation overflowed' +// error-pattern:thread 'main' panicked at 'arithmetic operation overflowed' // compile-flags: -C debug-assertions fn main() { diff --git a/src/test/run-fail/overflowing-rsh-1.rs b/src/test/run-fail/overflowing-rsh-1.rs index 63c808dc80a4e..d37ea693a9fcf 100644 --- a/src/test/run-fail/overflowing-rsh-1.rs +++ b/src/test/run-fail/overflowing-rsh-1.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'shift operation overflowed' +// error-pattern:thread 'main' panicked at 'shift operation overflowed' // compile-flags: -C debug-assertions #![warn(exceeding_bitshifts)] diff --git a/src/test/run-fail/overflowing-rsh-2.rs b/src/test/run-fail/overflowing-rsh-2.rs index 8b89e57c85bb5..a4b7028a474dc 100644 --- a/src/test/run-fail/overflowing-rsh-2.rs +++ b/src/test/run-fail/overflowing-rsh-2.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'shift operation overflowed' +// error-pattern:thread 'main' panicked at 'shift operation overflowed' // compile-flags: -C debug-assertions #![warn(exceeding_bitshifts)] diff --git a/src/test/run-fail/overflowing-rsh-3.rs b/src/test/run-fail/overflowing-rsh-3.rs index 8874587064c35..199da59eb53fd 100644 --- a/src/test/run-fail/overflowing-rsh-3.rs +++ b/src/test/run-fail/overflowing-rsh-3.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'shift operation overflowed' +// error-pattern:thread 'main' panicked at 'shift operation overflowed' // compile-flags: -C debug-assertions #![warn(exceeding_bitshifts)] diff --git a/src/test/run-fail/overflowing-rsh-4.rs b/src/test/run-fail/overflowing-rsh-4.rs index d74fd8a6b8e41..d0d89a310e26b 100644 --- a/src/test/run-fail/overflowing-rsh-4.rs +++ b/src/test/run-fail/overflowing-rsh-4.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'shift operation overflowed' +// error-pattern:thread 'main' panicked at 'shift operation overflowed' // compile-flags: -C debug-assertions // This function is checking that our (type-based) automatic diff --git a/src/test/run-fail/overflowing-rsh-5.rs b/src/test/run-fail/overflowing-rsh-5.rs index 249b952a5dca2..03588c3576ad3 100644 --- a/src/test/run-fail/overflowing-rsh-5.rs +++ b/src/test/run-fail/overflowing-rsh-5.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'shift operation overflowed' +// error-pattern:thread 'main' panicked at 'shift operation overflowed' // compile-flags: -C debug-assertions #![warn(exceeding_bitshifts)] diff --git a/src/test/run-fail/overflowing-rsh-6.rs b/src/test/run-fail/overflowing-rsh-6.rs index 1227f35444a60..914f6d2b5c4ce 100644 --- a/src/test/run-fail/overflowing-rsh-6.rs +++ b/src/test/run-fail/overflowing-rsh-6.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'shift operation overflowed' +// error-pattern:thread 'main' panicked at 'shift operation overflowed' // compile-flags: -C debug-assertions #![warn(exceeding_bitshifts)] diff --git a/src/test/run-fail/overflowing-sub.rs b/src/test/run-fail/overflowing-sub.rs index ce243a50e0b66..7eec7699d99c4 100644 --- a/src/test/run-fail/overflowing-sub.rs +++ b/src/test/run-fail/overflowing-sub.rs @@ -10,7 +10,7 @@ // ignore-pretty : (#23623) problems when ending with // comments -// error-pattern:thread '
' panicked at 'arithmetic operation overflowed' +// error-pattern:thread 'main' panicked at 'arithmetic operation overflowed' // compile-flags: -C debug-assertions #![feature(rustc_attrs)] diff --git a/src/test/run-fail/panic-set-unset-handler.rs b/src/test/run-fail/panic-set-unset-handler.rs index 6999aa715e791..b4b926f1ba3cb 100644 --- a/src/test/run-fail/panic-set-unset-handler.rs +++ b/src/test/run-fail/panic-set-unset-handler.rs @@ -8,7 +8,7 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -// error-pattern:thread '
' panicked at 'foobar' +// error-pattern:thread 'main' panicked at 'foobar' #![feature(std_panic, panic_handler)] use std::panic; diff --git a/src/test/run-fail/panic-take-handler-nop.rs b/src/test/run-fail/panic-take-handler-nop.rs index fec1db24adf09..928f73a2ab2ca 100644 --- a/src/test/run-fail/panic-take-handler-nop.rs +++ b/src/test/run-fail/panic-take-handler-nop.rs @@ -8,7 +8,7 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -// error-pattern:thread '
' panicked at 'foobar' +// error-pattern:thread 'main' panicked at 'foobar' #![feature(std_panic, panic_handler)] use std::panic; diff --git a/src/test/run-pass/multi-panic.rs b/src/test/run-pass/multi-panic.rs index 8e0b14128c83b..93e2a854ccb2a 100644 --- a/src/test/run-pass/multi-panic.rs +++ b/src/test/run-pass/multi-panic.rs @@ -15,7 +15,7 @@ fn check_for_no_backtrace(test: std::process::Output) { assert_eq!(it.next().map(|l| l.starts_with("thread '' panicked at")), Some(true)); assert_eq!(it.next(), Some("note: Run with `RUST_BACKTRACE=1` for a backtrace.")); - assert_eq!(it.next().map(|l| l.starts_with("thread '
' panicked at")), Some(true)); + assert_eq!(it.next().map(|l| l.starts_with("thread 'main' panicked at")), Some(true)); assert_eq!(it.next(), None); } From f67c4bb6ce12bf7f4c3c843a531be51cdf643c09 Mon Sep 17 00:00:00 2001 From: Wangshan Lu Date: Thu, 2 Jun 2016 18:53:40 +0800 Subject: [PATCH 2/2] Update cargo version in cargotest --- src/tools/cargotest/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/cargotest/main.rs b/src/tools/cargotest/main.rs index 7e688b5ec6b46..9332a8e5f6c06 100644 --- a/src/tools/cargotest/main.rs +++ b/src/tools/cargotest/main.rs @@ -25,7 +25,7 @@ const TEST_REPOS: &'static [Test] = &[ Test { name: "cargo", repo: "https://github.com/rust-lang/cargo", - sha: "26288f799427f9cc6e8bdddd782a17a8156ebc64", + sha: "7d79da08238e3d47e0bc4406155bdcc45ccb8c82", lock: None, }, Test {