Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange animation #10

Closed
lorisgir opened this issue Sep 24, 2018 · 4 comments · Fixed by #34
Closed

Strange animation #10

lorisgir opened this issue Sep 24, 2018 · 4 comments · Fixed by #34
Milestone

Comments

@lorisgir
Copy link

If I have any layout above the RecylerView and then I click on one of my items, the open animation is just fine, but the closing one behave strangely

@saket
Copy link
Owner

saket commented Sep 24, 2018

You'll have to help me help you here :)

Can you share a gist of your layout and a video?

@lorisgir
Copy link
Author

Sure.
I can replicate the problem by just adding a view in your sample app.
As you can see I just added a frame layout above the recycler.
screen shot 2018-09-24 at 20 27 07

Here a video of the problem: https://streamable.com/3yu2g
First part is at normal speed, second one is at 10x slow.
It appears that the recycler goes down a bit and then return to the normal position after the animation stops.
I'm just a newbie of Android, and I'm not used to see kotlin code. So I can't be helpful.

@saket
Copy link
Owner

saket commented Sep 27, 2018

That doesn't look nice. I'll try reproducing it this weekend and see what's going wrong.

@saket
Copy link
Owner

saket commented Aug 4, 2019

I'm late by many weekends but I just realized that this is happening because your InboxRecyclerView and ExpandablePageLayout do not have the same bounds. If you look at the sample app, you'll notice that the RV has a paddingTop to compensate for this.

That said, I've improved how the coordinates are calculated so you won't have to deal with this. It'll be included in the next major release. If you want to try it out early you use the SNAPSHOT:

implementation 'me.saket:inboxrecyclerview:2.0.0-SNAPSHOT'

@saket saket mentioned this issue Aug 4, 2019
@saket saket added this to the v2.0.0 milestone Aug 18, 2019
@saket saket closed this as completed in #34 Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants