Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Params outdir should *not* end with a trailing slash #27

Open
pditommaso opened this issue Jul 5, 2024 · 2 comments
Open

Params outdir should *not* end with a trailing slash #27

pditommaso opened this issue Jul 5, 2024 · 2 comments

Comments

@pditommaso
Copy link
Contributor

if not outdir.endswith("/"):
outdir += "/"

The outdir parameter should not end with a training slashed because this value is expected to be used as a prefix for other directory paths using the pattern ${params.outdir}/foo/bar and therefore, the trailing slash with result in double slashes

See for example

https://github.com/nf-core/rnaseq/blob/b89fac32650aacc86fcda9ee77e00612a1d77066/conf/modules.config#L54

https://github.com/nf-core/rnaseq/blob/b89fac32650aacc86fcda9ee77e00612a1d77066/conf/modules.config#L63

https://github.com/nf-core/rnaseq/blob/b89fac32650aacc86fcda9ee77e00612a1d77066/conf/modules.config#L71

@adamrtalbot
Copy link
Contributor

It's true but it fails validation with nf-validation before it can reach those string formatting steps. PR is open here but we're struggling to test properly right now. Once it's done we can remove this.

@adamrtalbot
Copy link
Contributor

nextflow-io/nf-validation#171 is merged and released. Once tested we can remove this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants