Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::experimental::dynarray no longer supported in array passing example #73

Open
GabrielDougherty opened this issue Apr 15, 2019 · 0 comments · May be fixed by #74
Open

std::experimental::dynarray no longer supported in array passing example #73

GabrielDougherty opened this issue Apr 15, 2019 · 0 comments · May be fixed by #74

Comments

@GabrielDougherty
Copy link

GabrielDougherty commented Apr 15, 2019

Hello, compiling functions/pass-arrays.cpp with GCC 7.3.0 fails with the following error:

gabriel@ubuntu-thinkpad:/tmp$ g++ -std=c++17 dynarr.cpp -o dynarr
dynarr.cpp:3:10: fatal error: experimental/dynarray: No such file or directory
 #include <experimental/dynarray>
          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

This is due to the inclusion of std::experimental::dynarray. It appears that std:dynarry didn't make it into c++14. Also, the link to std::experimental::dynarray documentation is broken since the page was removed from cppreference.

Would you be interested in removing dynarray from the example? I have submitted PR #74 if you are open to it. Thanks for maintaining this incredibly useful page, I have learned a lot from it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant