Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mrt < 1.0 Check Should Be Earlier in sgp4.js #47

Closed
thkruz opened this issue Sep 26, 2018 · 1 comment
Closed

mrt < 1.0 Check Should Be Earlier in sgp4.js #47

thkruz opened this issue Sep 26, 2018 · 1 comment

Comments

@thkruz
Copy link
Collaborator

thkruz commented Sep 26, 2018

Moving this check from line 421 to 386 would reduce unnecessary calculations if it is going to fail anyway.
@ezze
Copy link
Collaborator

ezze commented Mar 14, 2019

@thkruz, seems fine for me, thanks! 7578737

@ezze ezze closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezze @thkruz