Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't abuse libtool internals #1084

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Conversation

jsonn
Copy link
Contributor

@jsonn jsonn commented Oct 12, 2020

The whole internals of .libs are an implementation detail of libtool. I'm leaving the whole to_copy mess for now as it doesn't actually break something for pkgsrc, but the dependency certainly does.

The whole internals of .libs are an implementation detail of libtool. I'm leaving the whole `to_copy` mess for now as it doesn't actually break something for pkgsrc, but the dependency certainly does.
@alerque alerque merged commit 048c8b5 into sile-typesetter:master Oct 12, 2020
@alerque
Copy link
Member

alerque commented Oct 12, 2020

Thanks for these contributions @jsonn.

@alerque alerque added this to the v0.10.13 milestone Oct 12, 2020
@alerque alerque added the tooling Build tooling, release management, and packaging processes label Oct 12, 2020
@simoncozens
Copy link
Member

Thanks @jsonn!

@alerque, for future reference, what's the best way to edit contributed commits to conform to .commitlint rules? Check out manually and rebase -i?

@alerque
Copy link
Member

alerque commented Oct 12, 2020

@simoncozens For PRs like this one with a single commit using the "Squash and Merge" option allows you to write your own commit message. The downside of that is that you skip CI checks for the re-written commit message, but that's what I did here. For longer ones where you want to preserve the commit the history, yes a chekcout and rebase is necessary. To speed things up I use gh to make it easy to fetch and checkout a PR like this in such a way that you can also push back to it (gh pr checkout 1084), and also use git revise -i instead of rebase for faster iterating (it doesn't require stepping through each commit as the working copy, it basically just revises the commits directly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Build tooling, release management, and packaging processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants