fix appending text nodes before existing text nodes (jruby) #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is status? flavorjones/loofah#88 (comment) says this is Rails 4.2 with JRuby. |
|
I have confirmed this #1318 reduces loofah jruby errors. |
|
What is status? |
|
Merged! Will be in v1.7.1. Sorry for the delay in getting to this, and thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to fix at least some of Loofah's current test failures with JRuby I stumbled upon this.
I honestly do not understand what those 4 lines I removed from XmlNode are supposed to do - to me they look quite wrong since as a result the node to be inserted is simply discarded. Removing them fixed my test and caused no others to fail.
jruby 1.7.21 (1.9.3p551) 2015-07-07 a741a82 on OpenJDK 64-Bit Server VM 1.7.0_79-b14