New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted blob for file imports downloads an error message as file content #1405

Open

gjedlicska opened this issue Feb 22, 2023 · 0 comments

Assignees

Labels

bug

Contributor

gjedlicska commented Feb 22, 2023

There is a bit of breakage in the file imports / blobs flow.
Repro steps:

create a stream and import a file with file imports
after the import is done, delete the blob (via the api, since that is the only option for now)
trying to download the original file from the file uploads page returns a file that is:
- the same name as the original source file
- the content is an error message

Proper solution to this is:

not show the download button for missing source blobs
make sure not found blobs return a 404 on download instead of a file with error message as its content

gjedlicska added the bug label

gjedlicska self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment