Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invalid geometries rather than only throw exception #1928

Closed
AlexandruPopovici opened this issue Dec 22, 2023 · 1 comment
Closed
Assignees
Labels
[ viewer ] issues related to the 3d viewer package

Comments

@AlexandruPopovici
Copy link
Contributor

AlexandruPopovici commented Dec 22, 2023

Some geometries are invalid for good or otherwise reasons. The viewer will just throw an exception if such geometries are encountered and halt the entire flow. We probably need to ignore the invalid geometries and carry on with a warning/error message

Here's an example with some points https://speckle.xyz/streams/0ed2cdc8eb/commits/350c4e1a4d

Attributes with values < MIN_FLOAT or > MAX_FLOAT are assigned -Infinity/Infinity when casted. This of course breaks our mafs

@AlexandruPopovici AlexandruPopovici added the [ viewer ] issues related to the 3d viewer package label Dec 22, 2023
@AlexandruPopovici AlexandruPopovici self-assigned this Dec 22, 2023
@AlexandruPopovici
Copy link
Contributor Author

Migrated to Jira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[ viewer ] issues related to the 3d viewer package
Projects
None yet
Development

No branches or pull requests

1 participant