[bug]: Unable to mount and execute sieve script correctly

[winston0410]

What happened?

I notice that when I have a configuration like this, which is syntax wise similar with the example in doc

[session.rcpt]
script = "donotreply"

[sieve.trusted.scripts]
donotreply = '''
    require ["envelope", "reject"];

    if envelope :is "to" "noreply@foo.com" {
        reject "403 You can't reply to this address";
    }
'''

I will receive the following log, saying my configuration is corrupted

2024-08-23T14:07:40Z ERROR Configuration parse error (config.parse-error) details = "Failed to parse setting "session.rcpt.script": Invalid variable or constant "donotreply""

When I add quote around the script name at [session.rcpt].script, and change the config to this:

[session.rcpt]
script = "'donotreply'"

[sieve.trusted.scripts]
donotreply = '''
    require ["envelope", "reject"];

    if envelope :is "to" "noreply@foo.com" {
        reject "403 You can't reply to this address";
    }
'''

I don't see the ERROR log for configuration. But when I receive email, I notice this log

2024-08-23T14:22:24Z WARN Sieve script not found (sieve.script-not-found) listenerId = "smtp", localPort = 2025, remoteIp = 10.244.0.33, remotePort = 52436, id = "donotreply"

And the script is not executed.

How can we reproduce the problem?

The following is my stalwart config, but I believe most of it is irrelavent:

[server.listener."smtp"]
bind = ["[::]:2025"]
protocol = "smtp"

[server.listener."sieve"]
bind = ["[::]:4190"]
protocol = "managesieve"
tls.implicit = true

[server.listener."submissions"]
bind = ["[::]:4465"]
protocol = "smtp"
tls.implicit = true

[server.listener."imap"]
bind = ["[::]:9143"]
protocol = "imap"

[server.listener."imaptls"]
bind = ["[::]:9993"]
protocol = "imap"
tls.implicit = true

[server.listener."http"]
bind = ["[::]:8080"]
protocol = "http"

[storage]
data = "postgresql"
fts = "postgresql"
blob = "s3"
lookup = "redis"
directory = "sql"

[storage.encryption]
enable = false
append = false

[directory."sql"]
type = "sql"
store = "postgresql"

[directory."sql".columns]
name = "name"
description = "description"
secret = "secret"
email = "address"
quota = "quota"
class = "type"

[store."postgresql"]
# omitted

[store."postgresql".query]
name = "SELECT name, type, secret, description, quota FROM accounts WHERE name = $1 AND active = true"
members = "SELECT member_of FROM group_members WHERE name = $1"
recipients = "SELECT name FROM emails WHERE address = $1 ORDER BY name ASC"
emails = "SELECT address FROM emails WHERE name = $1 AND type != 'list' ORDER BY type DESC, address ASC"
verify = "SELECT address FROM emails WHERE address LIKE '%' || $1 || '%' AND type = 'primary' ORDER BY address LIMIT 5"
expand = "SELECT p.address FROM emails AS p JOIN emails AS l ON p.name = l.name WHERE p.type = 'primary' AND l.address = $1 AND l.type = 'list' ORDER BY p.address LIMIT 50"
domains = "SELECT 1 FROM emails WHERE address LIKE '%@' || $1 LIMIT 1"

[store."postgresql".init]
execute = [
    "CREATE TABLE IF NOT EXISTS accounts (name TEXT PRIMARY KEY, secret TEXT, description TEXT, type TEXT NOT NULL, quota INTEGER DEFAULT 0, active BOOLEAN DEFAULT TRUE)",
    "CREATE TABLE IF NOT EXISTS group_members (name TEXT NOT NULL, member_of TEXT NOT NULL, PRIMARY KEY (name, member_of))",
    "CREATE TABLE IF NOT EXISTS emails (name TEXT NOT NULL, address TEXT NOT NULL, type TEXT, PRIMARY KEY (name, address))",
]

[store."s3"]
# omitted

[store."s3".purge]
frequency = "30 5 *"

[store."redis"]
# omitted

[tracer."stdout"]
type = "stdout"
level = "trace"
ansi = false
enable = true


[tracer.trace.enable]
log-exporter = false
span-exporter = true

[authentication]
rate-limit = "20/1m"

[authentication.fallback-admin]
# omitted

[authentication.master]
# omitted

[config.resource]
webadmin = "https://github.com/stalwartlabs/webadmin/releases/latest/download/webadmin.zip"

[lookup.default]
hostname = "mail.stalwartdomain.com"

[session]
timeout = "5m"
transfer-limit = 262144000 # 250 MB
duration = "10m"

[session.extensions]
pipelining = true
chunking = true
requiretls = false

[session.connect]
greeting = "'Stalwart ESMTP at your service'"

[session.ehlo]
require = true
reject-non-fqdn = [{ if = "listener = 'smtp'", then = true }, { else = false }]

[session.mail]

[session.auth]
allow-plain-text = false
must-match-sender = true

[session.auth.errors]
total = 3
wait = "5s"

[server.tls]
enable = true
implicit = false
timeout = "30s"
ignore-client-order = true

[certificate."default"]
cert = "%{file:/etc/stalwart-mail/ssl/tls.crt}%"
private-key = "%{file:/etc/stalwart-mail/ssl/tls.key}%"

[auth.arc]
verify = "relaxed"

[auth.dkim]
verify = "relaxed"

[auth.dmarc]
verify = "relaxed"

[auth.iprev]
verify = "disable"

[report.analysis]
forward = true

[queue.outbound.tls]
dane = "optional"
mta-sts = "optional"

[session.rcpt]
directory = "'sql'"
script = "'donotreply'"
relay = false
subaddressing = true

[sieve.trusted.scripts]
donotreply = '''
    require ["envelope", "reject"];

    if envelope :is "to" "noreply@foo.com" {
        reject "403 You can't reply to this address";
    }
'''

Version

v0.9.x

What database are you using?

PostgreSQL

What blob storage are you using?

S3-compatible

Where is your directory located?

SQL

What operating system are you using?

Linux

Relevant log output

Related log output provided above

Code of Conduct

• I agree to follow this project's Code of Conduct

[mdecimus]

Check the logs when the server starts up, there might be a problem compiling the script.

[winston0410]

Hi, I have restarted the service with the current config. From the start up log I don't notice any issue

2024-08-23T18:46:01Z INFO Starting Stalwart Mail Server v0.9.2 (server.startup) version = 0.9.2
2024-08-23T18:46:01Z INFO Webadmin resource unpacked (resource.webadmin-unpacked) path = "/tmp/STALWART_WEBADMIN"
2024-08-23T18:46:01Z INFO Housekeeper process started (housekeeper.start)
2024-08-23T18:46:01Z INFO Network listener started (network.listen-start) listenerId = "http", localIp = ::, localPort = 8080, tls = false
2024-08-23T18:46:01Z INFO Network listener started (network.listen-start) listenerId = "imap", localIp = ::, localPort = 9143, tls = false
2024-08-23T18:46:01Z INFO Network listener started (network.listen-start) listenerId = "imaptls", localIp = ::, localPort = 9993, tls = true
2024-08-23T18:46:01Z INFO Network listener started (network.listen-start) listenerId = "sieve", localIp = ::, localPort = 4190, tls = true
2024-08-23T18:46:01Z INFO Network listener started (network.listen-start) listenerId = "smtp", localIp = ::, localPort = 2025, tls = false
2024-08-23T18:46:01Z INFO Network listener started (network.listen-start) listenerId = "submissions", localIp = ::, localPort = 4465, tls = true
2024-08-23T18:46:03Z INFO HTTP connection started (http.connection-start) listenerId = "http", localPort = 8080, remoteIp = 10.244.0.1, remotePort = 58316
2024-08-23T18:46:03Z INFO HTTP connection started (http.connection-start) listenerId = "http", localPort = 8080, remoteIp = 10.244.0.1, remotePort = 58302
2024-08-23T18:46:03Z INFO HTTP connection ended (http.connection-end) listenerId = "http", localPort = 8080, remoteIp = 10.244.0.1, remotePort = 58316, elapsed = 0ms
2024-08-23T18:46:03Z INFO HTTP connection ended (http.connection-end) listenerId = "http", localPort = 8080, remoteIp = 10.244.0.1, remotePort = 58302, elapsed = 0ms

[mdecimus]

I believe the docs are outdated, Sieve scripts are defined as follows:

[sieve.trusted.scripts.donotreply]
contents = '''
    require ["envelope", "reject"];

    if envelope :is "to" "noreply@foo.com" {
        reject "403 You can't reply to this address";
    }
'''