Card with less popular hashtag goes before card with more popular hashtag in Discover

[annadanchenko]

Description

Type: Bug

Summary: In discover, popular hashtags section shows most popular hashtags. So, card with hashtag "X" is shown first in the row if X is mentioned in more statuses than any other one. Next card is shown for the less amount of mentions in the statuses and so on. After user adds 9th hashtag - the sorting goes wrong, so cards are no longer sorted by the most number of mentions.

Expected behavior

Actual behavior

Reproduction

start from 02:35 to see the wrong behaviour: https://app.testfairy.com/projects/4803590-status/builds/7225894/sessions/6/?accessToken=sTyPEDjlv/zNCg9ipmnbrlfiojU

it also happens with 2 devices:
Android (one that looks at hashtags): https://app.testfairy.com/projects/4803622-status/builds/7225736/sessions/4/?accessToken=CjdbVOFYINkC1FcUE4wHPs2N5qc
iOs (one that changes hashtags): https://app.testfairy.com/projects/4803590-status/builds/7225894/sessions/8/?accessToken=bnPq2NeZqJTsoX4sr39A7cHoEgQ

• on device 1 add another device 2 as a contact, on device 2 add device 1 as a contact (in new 1-1 chat tap on Add a contact)
• open Discover tab on device 2
• all changes below do on device 1 and check how cards are shown in Discover under Popular hashtags on device 2
• Open profile
• Remove default status
• type How to handle multiple numbers on phone account? #1 and tap on username -> on device 2 check that Discover shows card with How to handle multiple numbers on phone account? #1 as hashtag in top left corner of the card and (1) as count of statuses in top right corner of the card
• type new code structure #2, so as result there is #1 #2 in status and tap on username -> on device 2 check that Discover shows card with #1 and (2) as count and `new code structure #2 and (1) as count of statuses
• add to status iOS Build setup #3 and tap on username -> #1 #2 #3 and check how cards are displayed
• add to status better java/ios interop with go-ethereum, expose xeth ? #4 and tap on username -> #1 #2 #3 #4 and check how cards are displayed
• add to status hash comparison with circleci artifacts #5 and tap on username -> #1 #2 #3 #4 #5 and check how cards are displayed
• add to status merge light-api with develop #6 and tap on username -> #1 #2 #3 #4 #5 #6 and check how cards are displayed. On the first place in the row of card there is How to handle multiple numbers on phone account? #1 with 6 mentions, than new code structure #2 with 5 mentions and so on to merge light-api with develop #6 with 1 mention
• delete the statuses, type chat dapp permissions #7 and tap on username, so the status string is just #7 - check that card is displayed at the very end with 1 mention
• delete chat dapp permissions #7, type Refactoring #8 and tap on username - check that card is displayed at the very end with 1 mention
• now is the place where bug happen, so you might want to check how all 8 cards are displayed and that order is correct: How to handle multiple numbers on phone account? #1 has 6 mentions, new code structure #2 has 5... Also pay attention to the content of the cards
• delete Refactoring #8, type Protocol integration #9 and tap on username - check the order of the cards and their content now

Additional Information

• Status version: nightly build 96. Status version 0.9.10-422-g6d5251ad+
• Operating System:
  real device Pixel XL, Android 8.0
  real device iPhone 6s, iOS 10.3.1

[annadanchenko]

Discover feature is removed