Question: pipe stream to POST request

[mulyoved]

Have this code which work fine with request, what will be the correct way to call it in retry-request?

var pipe = fs
  .createReadStream(fileName)
  .pipe(
  request({ url: url, method: 'POST'}));

pipe
  .on('error', function(err) {
    console.error(err);
  })
  .on('response', function (answer) {
  })
  .on('complete', function (answer) {
  })
  .on('end', function(answer) {
  });

[stephenplusplus]

It should look like:

var pipe = fs
  .createReadStream(fileName)
  .pipe(
-  request({ url: url, method: 'POST'}));
+  retryRequest({ url: url, method: 'POST'}));

pipe
  .on('error', function(err) {
    console.error(err);
  })
  .on('response', function (answer) {
  })
  .on('complete', function (answer) {
  })
  .on('end', function(answer) {
  });

Can you let me know if that works?

[mulyoved]

No this does not work, all look OK but result seem to be empty stream.

[stephenplusplus]

Sorry, I don't know how I missed the POST part of this, since it was all over your question.

Using retryRequest with post requests is not currently supported, as it's quite a difficult task to implement. Conditionally rewinding & re-piping a stream already in the hands of a user is not something I've yet figured out how to do, if it is even possible at all. PRs welcome if you know the trick!

[stephenplusplus]

Left a note in the readme that points here.

[mulyoved]

I can see why stream POST is an issue, I ended up add the retry logic in an upper level.

[ruffle1986]

Sorry, it's a bit irrelevant. @stephenplusplus, how did you achieve the red and green lines to show the changes in your comment?

[stephenplusplus]

No problem @ruffle1986. I thought it was pretty cool the first time I saw it, too.

```diff
var pipe = fs
  .createReadStream(fileName)
  .pipe(
-  request({ url: url, method: 'POST'}));
+  retryRequest({ url: url, method: 'POST'}));

⏬

var pipe = fs
  .createReadStream(fileName)
  .pipe(
-  request({ url: url, method: 'POST'}));
+  retryRequest({ url: url, method: 'POST'}));

[surya1024]

I have similar issue even with GET but work as expected with request

Using pump returns a empty response

  pump(req, retryRequest({...options, url: url}), res, (err) => console.log(err));

Using pipe gives a "write after end" error

req.pipe(retryRequest({url: url, ...options}))
      .on('error', (req, res, next) => console.log("error"))
      .pipe(res)

[stephenplusplus]

@surya1024 thank you for reporting. Would you mind opening a new issue for that?