Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QtTest.pyi #50

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Update QtTest.pyi #50

merged 2 commits into from
Jul 9, 2020

Conversation

Djedouas
Copy link
Contributor

@Djedouas Djedouas commented Jul 8, 2020

Fix attributes of QAbstractItemModelTester.FailureReportingMode which were attributes of QAbstractItemModelTester.

Fix attributes of `QAbstractItemModelTester.FailureReportingMode` which were attributes of `QAbstractItemModelTester`.
Copy link
Collaborator

@stlehmann stlehmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me. Please add an entry to the Changelog and you are ready to get merged.

Added PR #50 description
@Djedouas
Copy link
Contributor Author

Djedouas commented Jul 8, 2020

Changelog updated!
Good practice ;-)

@stlehmann stlehmann merged commit 2489fe9 into python-qt-tools:master Jul 9, 2020
@stlehmann
Copy link
Collaborator

Great, thanks for your contribution 🎉

bluebird75 pushed a commit to bluebird75/PyQt5-stubs that referenced this pull request Aug 24, 2021
bluebird75 pushed a commit to bluebird75/PyQt5-stubs that referenced this pull request Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants