Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Add CLI version to context #21999

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 8, 2023

What I did

We don't enrich boot events with metadata so that it doesn't affect perf, but we can include the CLI version without additional overhead, and it is useful for understanding whether we've fixed bugs across versions.

How to test

In a sandbox:

STORYBOOK_TELEMETRY_DEBUG=1 yarn storybook 

@shilman shilman added maintenance User-facing maintenance tasks telemetry labels Apr 8, 2023
@shilman shilman requested a review from tmeasday April 8, 2023 03:56
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm. Should we test for some value in the telemetry e2e tests?

code/lib/cli/src/generate.ts Outdated Show resolved Hide resolved
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 8, 2023
@shilman
Copy link
Member Author

shilman commented Apr 10, 2023

@tmeasday tests FTW!! caught a bug in angular, which bypasess the CLI. this is a little messier than it started out as. please re-review and lmk if you have a better idea about how to structure it.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe would be good to refactor this angular stuff to avoid the duplication though.

@shilman shilman merged commit 4f967aa into next Apr 11, 2023
@shilman shilman deleted the shilman/cli-version-telemetry branch April 11, 2023 14:11
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 11, 2023
shilman added a commit that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants