Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed opacity from list-item color #22074

Conversation

adityaKrModak
Copy link
Contributor

Closes #21990

What I did

I've updated the color property in the Item styled component which was getting inherited in the Left and Right styled components of ListItem.tsx.

How to test

Here is the before and after screenshots:

Pasted Graphic

Pasted Graphic 1

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

removed transparentize() from color property
@valentinpalkovic valentinpalkovic self-assigned this Apr 17, 2023
@valentinpalkovic valentinpalkovic added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 17, 2023
@valentinpalkovic valentinpalkovic merged commit 0cc12b1 into storybookjs:next May 8, 2023
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 9, 2023
shilman pushed a commit that referenced this pull request May 9, 2023
…tem-color

fix: removed opacity from list-item color
@shilman shilman mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SB 7 Left/Right in TooltipLinkList are color 0.5 - should be 1.0
4 participants