Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add addon query-params to list of SB7 incompatible addons #22095

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

jonniebigodes
Copy link
Contributor

With this pull request, the addon-queryparams addon is added to the list of incompatible addons per this comment and also based on a cursory search, the addon itself is no longer being actively maintained since 6.4 and to avoid further issues it would be on our best interest to also add this one as well.

What was done:

  • Updated the list of incompatible addons in the CLI to feature the mentioned addon

@jonniebigodes jonniebigodes added maintenance User-facing maintenance tasks cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 14, 2023
@jonniebigodes jonniebigodes self-assigned this Apr 14, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yannbf yannbf changed the title Chore: (CLI) Adds addon query params to list of incompatible addons CLI: Add addon query-params to list of incompatible addons Apr 19, 2023
@yannbf yannbf changed the title CLI: Add addon query-params to list of incompatible addons CLI: Add addon query-params to list of SB7 incompatible addons Apr 19, 2023
@yannbf yannbf merged commit c10da37 into next Apr 19, 2023
@yannbf yannbf deleted the add_addon_query_params_to_incompatible branch April 19, 2023 08:54
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 24, 2023
shilman pushed a commit that referenced this pull request Apr 24, 2023
…incompatible

CLI: Add addon query-params to list of SB7 incompatible addons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants