Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Do not show a migration summary on sb init #22109

Merged
merged 1 commit into from
May 10, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 15, 2023

Closes #

What I did

This PR makes the sb init not display the migration summary, as it's quite confusing to see notes about migration when starting a fresh Storybook project.

Before:
image

After:
image

How to test

  1. build the cli
  2. run code/lib/cli/bin/index.js init on a project
  3. notice that there's no summary anymore

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 15, 2023
@shilman
Copy link
Member

shilman commented Apr 16, 2023

Would it be better to simply not run automigrations at all on init?

@yannbf
Copy link
Member Author

yannbf commented Apr 16, 2023

Would it be better to simply not run automigrations at all on init?

We've asked ourselves this question a few times, the reason we run them is because Storybook does not support Typescript out of the box for a subset of projects (then we run the babelrc migration). I'd love if we didn't have to run them!

We also ask whether people would like to install the eslint plugin, but that one in particular could be done in a different way for sure

@shilman shilman merged commit 415f788 into next May 10, 2023
@shilman shilman deleted the fix/hide-migration-summary-on-init branch May 10, 2023 13:18
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 12, 2023
shilman added a commit that referenced this pull request May 12, 2023
…-on-init

CLI: Do not show a migration summary on sb init
@shilman shilman mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants