Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Migrate @storybook/postinstall and @storybook/router to strict TS #22200

Conversation

kuriacka
Copy link
Contributor

@kuriacka kuriacka commented Apr 21, 2023

Issue #22176

What I did

Migrate @storybook/postinstall and @storybook/router to strict-ts

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen
Copy link
Contributor

kasperpeulen commented Apr 25, 2023

Thanks @kuriacka!
Can you rebase them on the latest next! (Or merge next in)

@kuriacka
Copy link
Contributor Author

@kasperpeulen Rebase done.

@kasperpeulen kasperpeulen force-pushed the kuriacka/strict-ts-postinstall-and-router branch from 62feb57 to 2d7d952 Compare April 26, 2023 09:32
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperpeulen kasperpeulen merged commit 71024ff into storybookjs:next May 1, 2023
@jonniebigodes
Copy link
Contributor

@kuriacka, one thing left to address as part of this initiative and the amazing work you did by helping us convert Storybook's packages to allow stricter TypeScript support. If you're ok with it, can you message me on our Discord server (same username) so that I can follow up with you?

Hope you have a fantastic day.

Stay safe

@kuriacka
Copy link
Contributor Author

@jonniebigodes, I was unable to send you message via Discord. How can I help you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants