Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: virtual modules excluded for babel-loader #22331

Merged
merged 3 commits into from
May 3, 2023
Merged

Conversation

ndelangen
Copy link
Member

Closes #22300

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the right approach! Do we need to do similar for Vite do you think?

@ndelangen
Copy link
Member Author

@tmeasday I don't know if vite suffers from the same problem, I though it didn't..
So I think, doing the same for vite isn't needed.

I was thinking that maybe there would be a need to add some sort of loader for ONLY these entries, possibly an esbuild-loader or something.

It seems though that it's not needed, considering the sandboxes are working?!

@tmeasday
Copy link
Member

tmeasday commented May 3, 2023

It seems though that it's not needed, considering the sandboxes are working?!

I think that's right. As I said, it's very simple handwritten JS. I guess we just need to be slightly careful we don't use any advanced JS in there, but I think by the nature of being JS (not TS) that's not likely.

@tmeasday I don't know if vite suffers from the same problem, I though it didn't..
So I think, doing the same for vite isn't needed.

I guess Vite is not going to suffer from this exact problem (the stripped comment is for webpack after all), so I guess you are right.

@ndelangen ndelangen marked this pull request as ready for review May 3, 2023 11:22
@ndelangen ndelangen changed the title Experiment: virtual modules excluded for babel-loader Fix: virtual modules excluded for babel-loader May 3, 2023
@ndelangen
Copy link
Member Author

I marked this ready for review then.

@tmeasday tmeasday added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 3, 2023
@tmeasday tmeasday merged commit 2350c14 into next May 3, 2023
@tmeasday tmeasday deleted the norbert/fix-22300 branch May 3, 2023 23:55
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 5, 2023
shilman pushed a commit that referenced this pull request May 5, 2023
Fix: virtual modules excluded for babel-loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug configuration babel / webpack patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Stories glob incorrectly matching test files
3 participants