Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building pbandk requires android #244

Open
JohnLCaron opened this issue Nov 21, 2022 · 3 comments
Open

Building pbandk requires android #244

JohnLCaron opened this issue Nov 21, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed platform-android

Comments

@JohnLCaron
Copy link
Contributor

JohnLCaron commented Nov 21, 2022

0.14.3-SNAPSHOT Head (11/18/22)

./gradlew clean

The Kotlin source set androidAndroidTestRelease was configured but not added to any Kotlin compilation. You can add a source set to a target's compilation by connecting it with the compilation's default source set using 'dependsOn'.
See https://kotlinlang.org/docs/reference/building-mpp-with-gradle.html#connecting-source-sets
$ ./gradlew assemble

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':pbandk-runtime:compileDebugAidl'.
> SDK location not found. Define location with an ANDROID_SDK_ROOT environment variable or by setting the sdk.dir path in your project's local properties file at '/home/snake/dev/github/pbandk/local.properties'.

Would be nice if it skipped building android if SDK is not found.
Sorry I dont know enough gradle to send a PR.

./gradlew --version


Gradle 7.3

Build time: 2021-11-09 20:40:36 UTC
Revision: 96754b8c44399658178a768ac764d727c2addb37

Kotlin: 1.5.31
Groovy: 3.0.9
Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM: 17.0.1 (Oracle Corporation 17.0.1+12-LTS-39)
OS: Linux 5.15.0-53-generic amd64

@JohnLCaron
Copy link
Contributor Author

Also happens on windows:

$ ./gradlew.bat --version


Gradle 7.3

Build time: 2021-11-09 20:40:36 UTC
Revision: 96754b8c44399658178a768ac764d727c2addb37

Kotlin: 1.5.31
Groovy: 3.0.9
Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM: 17.0.5 (Oracle Corporation 17.0.5+9-LTS-191)
OS: Windows 10 10.0 amd64

@garyp garyp added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers platform-android labels Nov 22, 2022
@garyp
Copy link
Collaborator

garyp commented Jan 5, 2023

We don't have resources right now to implement this but would welcome a contribution. For someone familiar with Gradle (or wanting to learn it), this probably wouldn't be a very difficult task. I've personally often wanted the ability to tell Gradle to skip building certain platforms (or, conversely, build for only a single platform) while doing development since a generic ./gradlew assemble takes a very long time.

@garyp
Copy link
Collaborator

garyp commented Jan 5, 2023

Having this would also help with implementing one of the ideas in #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed platform-android
Projects
None yet
Development

No branches or pull requests

2 participants