Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow retrieveUpcoming to use only the subscription #591

Closed
reacuna opened this issue Apr 19, 2019 · 2 comments · Fixed by #593
Closed

Feature request: Allow retrieveUpcoming to use only the subscription #591

reacuna opened this issue Apr 19, 2019 · 2 comments · Fixed by #593

Comments

@reacuna
Copy link

reacuna commented Apr 19, 2019

According the the docs for version 2019-03-14 (maybe earlier, I'm not sure), the customer parameter is required only if the subscription parameter is not set.
The implementation however, always uses the first parameter as the customer id:

var url = 'upcoming?customer=' + urlData.customerId;

Any chance to allow to use a subscription id without a customer?

@remi-stripe
Copy link
Contributor

@reacuna Thanks a lot for the report. I had no idea we hardcoded the customer id in the query params. We'll work on a fix!

@remi-stripe
Copy link
Contributor

@reacuna This was fixed in stripe-node 6.30.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants