Add button color, return URL, allowsDelayedPaymentMethods, and billing details to JS, iOS, and Android #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
porter-stripe
commented
Sep 20, 2021
•
porter-stripe
commented
- Adds button color, return URL, allowsDelayedPaymentMethods, primary button color, and billing details in JS and iOS
- This is going into a feature branch in my fork, then eventually into master. For now I don't have permissions to the react native repo.
- Added allowsDelayedPaymentMethods, billing details, and primary button color to Android
porter-stripe
commented
Sep 20, 2021
porter-stripe
changed the title
yuki-stripe
reviewed
Sep 27, 2021
| @@ -40,7 +44,20 @@ export declare namespace PaymentSheet { | |||
| merchantCountryCode?: string; | |||
| testEnv?: boolean; | |||
| }; | |||
|
|
|||
| export interface Address { | |||
There was a problem hiding this comment.
how do users see documentation for these things? I didn't find it in /docs, do they use the native SDK docs?
There was a problem hiding this comment.
That's a good question, this SDK (react native) isn't documented well. There will need to be some effort made to get that fixed. Not sure what that looks like in the short-term, there's many types and interfaces not documented at all...
|
@brnunes-stripe @michelleb-stripe latest commit 849df3d contains Kotlin/Android updates if you're interested. |
porter-stripe
changed the title
yuki-stripe
approved these changes
Oct 15, 2021
|
@yuki-stripe correct, once iOS and Android GA I'll throw up a quick change pointing to the latest versions, then we'll publish the RN package! Merging this into a feature branch for now... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.