-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add allowed_instance_types
to instance_requirements
#267
feat: Add allowed_instance_types
to instance_requirements
#267
Conversation
Additional tests I did locally: Terraform plan with the following combinations:
2
3
4
The failure in test 4 was expected. |
I see there is an issue template that for some reason I didn't see when creating this :) |
@antonbabenko , ready for review |
the min required AWS provider version throughout will need to be raised to |
…` parameter and for ALB module updates in examples
Thank you @bryantbiggs I had to go with Basically, I can't use Happy to do that if you think its worth it Also added a note to the README re contributions. |
The min version is to declare the modules minimum requirements - it doesn't mean you can pin to this exact version in an example because the use of other resources/modules in an example may require a higher version. It is just a lower bound pin to declare the minimum requirements for the module itself; Terraform will use this when resolving the version requirements in conjunction with other modules and user defined version requirements |
@bryantbiggs thank you, should be sorted now |
allowed_instance_types
to instance_requirements
(#265)allowed_instance_types
to instance_requirements
This PR is included in version 7.5.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
The aws_launch_template resource supports an
allowed_instance_types
field in theinstance_requirements
block.This terraform module does already accept the
excluded_instance_types
field but not theallowed_instance_types
field documented on the resource.Motivation and Context
Closes #265
Breaking Changes
No - I've included an update the
excluded_instance_types
to ensure compatibility when either field is present.How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request