Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 VPC Endpoint for public subnets #427

Closed
alexisgunst opened this issue Apr 8, 2020 · 2 comments · Fixed by #502
Closed

S3 VPC Endpoint for public subnets #427

alexisgunst opened this issue Apr 8, 2020 · 2 comments · Fixed by #502

Comments

@alexisgunst
Copy link

Hello there,

Can someone explain to me why S3 Endpoint is enabled for public subnets?
As far as I understand AWS, this is not necessary. Or at least, it should be an option.

Would it be possible to add an extra variable like enable_public_s3_endpoint ?

resource "aws_vpc_endpoint_route_table_association" "public_s3" {
count = var.create_vpc && var.enable_s3_endpoint && length(var.public_subnets) > 0 ? 1 : 0
vpc_endpoint_id = aws_vpc_endpoint.s3[0].id
route_table_id = aws_route_table.public[0].id
}

@DrFaust92
Copy link
Contributor

I can open a PR to the enable_public_s3_endpoint flag with default to true not to break the module but the main reason to a VPC Endpoint in a public subnet is probably compliance/security
you can restrict access to bucket based on vpc endpoint id

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants