Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add folder clean up #47

Merged
merged 4 commits into from
Mar 29, 2021
Merged

feat: add folder clean up #47

merged 4 commits into from
Mar 29, 2021

Conversation

bharathkkb
Copy link
Member

Currently cleanup does not delete folders that are created during test CI runs. This can result in MAX_CHILD_FOLDERS_VIOLATION and require manual clean up. This PR address this by

  • removing all folders that are grandchildren of TARGET_FOLDER_ID
  • if a folder is not empty of any reason (exclude label/project age) delete fails as expected and is logged

@bharathkkb
Copy link
Member Author

/gcbrun

@comment-bot-dev
Copy link

comment-bot-dev commented Feb 3, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 6d001bb into master Mar 29, 2021
@bharathkkb bharathkkb deleted the add-folder-cleanup branch March 29, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bharathkkb @comment-bot-dev @morgante