Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add grant_token_creator flag for pubsub #52

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

franviera92
Copy link
Contributor

Is necessary configure variable grant_token_creator in module pubsub to with value false.

Analysis with checkov detect vulnerability

Check: CKV_GCP_41: "Ensure that IAM users are not assigned the Service Account User or Service Account Token Creator roles at project level"
FAILED for resource: google_project_iam_member.token_creator_binding
File: /tfplan.json:390-395
Guide: https://docs.bridgecrew.io/docs/bc_gcp_iam_3
391 | "values": {
392 | "condition": [],
393 | "member": "serviceAccount:service-97749614032@gcp-sa-pubsub.iam.gserviceaccount.com",
394 | "project": "tc-sc-bi-bigdata-dp-pmo-dev",
395 | "role": "roles/iam.serviceAccountTokenCreator"
Check: CKV_GCP_49: "Ensure no roles that enable to impersonate and manage all service accounts are used at a project level"
FAILED for resource: google_project_iam_member.token_creator_binding
File: /tfplan.json:390-395
Guide: https://docs.bridgecrew.io/docs/bc_gcp_iam_10
391 | "values": {
392 | "condition": [],
393 | "member": "serviceAccount:service-97749614032@gcp-sa-pubsub.iam.gserviceaccount.com",
394 | "project": "tc-sc-bi-bigdata-dp-pmo-dev",
395 | "role": "roles/iam.serviceAccountTokenCreator"

@comment-bot-dev
Copy link

comment-bot-dev commented Mar 31, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb changed the title chore: config grant_token_creator in module pubsub fix: add grant_token_creator flag for pubsub Mar 31, 2021
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @franviera92

@bharathkkb bharathkkb merged commit 7fee659 into terraform-google-modules:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants