Fix: switch to reusable GitHub workflows #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduce duplication when we're running linter and unit tests - Move the please-release & publish steps into the same file to show that they are related. tehe document start markers in yaml allow for this. Signed-off-by: Dan Webb <dan.webb@damacus.io>
These templates are stored in test-kitchen/.github Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
|
Still has a few mdl issues holding it back |
As per the publication to NPM example we noq publish to GitHub and RubyGems as part of the please-release workflow https://github.com/google-github-actions/release-please-action#automating-publication-to-npm Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
kasif-adnan
approved these changes
Apr 20, 2022
This was referenced Apr 20, 2022
| @@ -286,8 +287,8 @@ platforms: | |||
| image_urn: Canonical:UbuntuServer:14.04.4-LTS:latest | |||
| vnet_id: /subscriptions/b6e7eee9-YOUR-GUID-HERE-03ab624df016/resourceGroups/pendrica-infrastructure/providers/Microsoft.Network/virtualNetworks/pendrica-arm-vnet | |||
| subnet_id: subnet-10.1.0 | |||
| public_ip: true | |||
| public_ip_sku: Standard | |||
| public_ip: true | |||
There was a problem hiding this comment.
@damacus was this indentation change intended?
There was a problem hiding this comment.
sigh, definitely not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These templates are stored in test-kitchen/.github
Check List