Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two updates to ?dplyr_extending #6695

Closed
DavisVaughan opened this issue Feb 8, 2023 · 0 comments · Fixed by #6701
Closed

Two updates to ?dplyr_extending #6695

DavisVaughan opened this issue Feb 8, 2023 · 0 comments · Fixed by #6701
Milestone

Comments

@DavisVaughan
Copy link
Member

https://dplyr.tidyverse.org/reference/dplyr_extending.html


If you have data frame attributes that don't depend on the rows or columns (and should unconditionally be preserved), you don't need to do anything.

If you extend a "data.frame" rather than a tibble, then you need to provide a [.class method to make it preserve attributes. See #6689 and #6691


Current usage section for mutate() should be updated to also include that it uses 1-D [ to implement .keep, and that is unconditionally called even if keeping everything.


Maybe do a pass through everything in Current usage to see if we are up to date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant