-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
na.rm have no effect in geom_col with position_stack #3532
Comments
@hadley will you be ok with |
Hmmm, wouldn't that be inconsistent with other geoms? Then the missings would just be silently removed. |
The geom still implements |
Ok, makes sense. |
Hmm... this is actually less obvious. Since the position is calculated before then I can't really see this being handled gracefully, but we can add a switch to the position so that it can be silenced at least |
I'm seeing a similar issue with geom_area().
|
Usually
na.rm = TRUE
will hide the warnings of removing NAs. However when usingposition_stack
withgeom_col
, the warning cannot be turned off.It seemed that the other usage of
remove_missing
in geom_* take the na.rm parameter, butposition_stack
doesn't take it as parameter thus no way to hide the warning. Maybeposition_stack
was supposed to take cleaned data fromgeom_col
too.The text was updated successfully, but these errors were encountered: