Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on stat() and ..var..-notation? #3693

Closed
yutannihilation opened this issue Jan 7, 2020 · 2 comments · Fixed by #4950
Closed

Warn on stat() and ..var..-notation? #3693

yutannihilation opened this issue Jan 7, 2020 · 2 comments · Fixed by #4950

Comments

@yutannihilation
Copy link
Member

After #3534, now we have 3 different ways to access the calculated variables:

  • after_stat(var)
  • stat(var)
  • ..var..

Though it seems very difficult to remove other syntax than after_stat(), I think we should promote the most proper one a bit more eagerly to avoid confusion. Can we warn on the usage of stat() and ..var..-notation?

@yutannihilation yutannihilation changed the title Deprecate on stat() and ..var..-notation? Warn on stat() and ..var..-notation? Jan 7, 2020
@thomasp85
Copy link
Member

I think we should (promote it more aggressively), but I also think instantly deprecating the other flavours upon release is a bit too agressive. It will be mentioned in the release post, and all docs have been updated to use it (and stat() has been removed from the doc)

I think we should begin warning sometime after this release

@yutannihilation
Copy link
Member Author

Thanks, fair enough. But, I'm a bit pessimistic about the impact of docs as I see many people even don't know the existence of stat() after 1.5 years passed since the release (version 3.0.0)...

Anyway, I agree with you it's not the time to add warnings in the upcoming release. Let's wait for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants