conflict of coord_flip() with annotation_logticks()

[DSLituiev]

This behaves exactly like the closed issue #881, still here in ggplot2 version 3.3.0

Using a bit modified example

a <- ggplot(msleep, aes(bodywt, brainwt)) +
 geom_point(na.rm = TRUE) +
 scale_x_log10(
   breaks = scales::trans_breaks("log10", function(x) 10^x),
   labels = scales::trans_format("log10", scales::math_format(10^.x))
 ) +
 scale_y_log10(
   breaks = scales::trans_breaks("log10", function(x) 10^x),
   labels = scales::trans_format("log10", scales::math_format(10^.x))
 )

This works:

a + coord_flip()

And this works:

a + annotation_logticks()

Now,

a + coord_flip() + annotation_logticks()

returns error: Error in unit(xticks$x, "native") : 'x' and 'units' must have length > 0

[clauswilke]

I can confirm this problem.

library(ggplot2)

a <- ggplot(msleep, aes(bodywt, brainwt)) +
  geom_point(na.rm = TRUE) +
  scale_x_log10(
    breaks = scales::trans_breaks("log10", function(x) 10^x),
    labels = scales::trans_format("log10", scales::math_format(10^.x))
  ) +
  scale_y_log10(
    breaks = scales::trans_breaks("log10", function(x) 10^x),
    labels = scales::trans_format("log10", scales::math_format(10^.x))
  )

a + annotation_logticks()

a + annotation_logticks() + coord_flip()
#> Error in unit(xticks$x, "native"): 'x' and 'units' must have length > 0

^{Created on 2020-04-19 by the reprex package (v0.3.0)}

It arises because annotation_logticks() doesn't properly use the coord to figure out where to draw ticks. It just assumes that the x axis is bottom/top and the y axis is left/right. See e.g.:

ggplot2/R/annotation-logticks.r

Lines 136 to 142 in c7f9398

	if (grepl("[b|t]", sides)) {
	# Get positions of x tick marks
	xticks <- calc_logticks(
	base = base,
	minpow = floor(panel_params$x.range[1]),
	maxpow = ceiling(panel_params$x.range[2]),

[clauswilke]

The correct way to obtain the ranges would probably be something like this (from geom_hline()):

ggplot2/R/geom-hline.r

Lines 48 to 51 in c7f9398

	ranges <- coord$backtransform_range(panel_params)
	data$x <- ranges$x[1]
	data$xend <- ranges$x[2]

[clauswilke]

Or just coord$range(panel_params), not sure off the top of my head.